Fix propagation of native category #33504
Conversation
|
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ebullient
force-pushed
the
docs-errors
branch
3 times, most recently
from
293fbfe to
144fdda
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
@ebullient - Super. All guides (including the 4 raised in issue #32953) are now displayed as expected when you select the 'Native' filter on the landing page. Thank you 👍
| @@ -3,8 +3,9 @@ This guide is maintained in the main Quarkus repository | |||
| and pull requests should be submitted there: | |||
| https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc | |||
| //// | |||
There was a problem hiding this comment.
Do we have a redirect in place for the micrometer.adoc file you removed?
There was a problem hiding this comment.
I made it.. did I submit it is the question.
Let me retrace my steps yesterday to see when I got distracted and dropped the thread...
There was a problem hiding this comment.
quarkusio/quarkusio.github.io#1709
But it doesn't point to the tutorial, it points here: docs/src/main/asciidoc/telemetry-micrometer.adoc
| @@ -3,9 +3,10 @@ This guide is maintained in the main Quarkus repository | |||
| and pull requests should be submitted there: | |||
| https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc | |||
| //// | |||
| [id="deploy-kubernetes"] | |||
There was a problem hiding this comment.
doc ids are often used downstream in unified views or other generated TOC. It functions as a subsection id of a larger whole.
- Add native category to related tutorials - Fix preamble spacing / doc attribute detection in native reference - Add a few missing id values - Fix summary/preamble for maven & gradle tooling guides Fixes quarkusio#32953
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Fixes #32953