Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc - log a WARN if we encounter unproxyable JDK class since we cannot transform it either #33440

Merged
merged 1 commit into from
May 18, 2023
+7 −1
Merged

Arc - log a WARN if we encounter unproxyable JDK class since we cannot transform it either #33440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Methods.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,16 @@ private static boolean skipForClientProxy(MethodInfo method, boolean transformUn
.add(NameAndDescriptor.fromMethodInfo(method));
return false;
}

// in case we want to transform classes but are unable to, we log a WARN
LOGGER.warn(String.format(
"Final method %s.%s() is ignored during proxy generation and should never be invoked upon the proxy instance!",
className, method.name()));
} else {
// JDK classes with final method are not proxyable and not transformable, we skip those methods and log a WARN
LOGGER.warn(String.format(
"JDK class %s with final method %s() cannot be proxied and is not transformable. " +
"This method will be ignored during proxy generation and should never be invoked upon the proxy instance!",
className, method.name()));
}
return true;
}
Expand Down