Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc - log a WARN if we encounter unproxyable JDK class since we cannot transform it either #33440

Merged
merged 1 commit into from
May 18, 2023

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented May 17, 2023

Fixes #33417

An example of when this happens is creating an @ApplicationScoped bean for AtomicBoolean which has many methods final. For each such method, there will be a log looking something like this:

2023-05-17 13:31:33,401 WARN [io.qua.arc.pro.Methods] (build-17) JDK class java.util.concurrent.atomic.AtomicBoolean with final method weakCompareAndSetVolatile() cannot be proxied and is not transformable. This method will be ignored during proxy generation and should never be invoked upon the proxy instance!

@manovotn manovotn requested review from Ladicek and mkouba May 17, 2023 11:38
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label May 17, 2023
@Ladicek
Copy link
Contributor

Ladicek commented May 17, 2023

LGTM otherwise :-)

@manovotn manovotn force-pushed the clientProxyWithFinalMethods branch from fedb3c4 to abdb158 Compare May 17, 2023 11:49
@manovotn manovotn added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 17, 2023
@quarkus-bot

This comment has been minimized.

@manovotn manovotn force-pushed the clientProxyWithFinalMethods branch from abdb158 to c4bfc05 Compare May 18, 2023 09:41
@quarkus-bot
Copy link

quarkus-bot bot commented May 18, 2023

Failing Jobs - Building c4bfc05

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/vertx/deployment 
! Skipped: extensions/agroal/deployment extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 365 more

📦 extensions/vertx/deployment

io.quarkus.vertx.mdc.VertxMDCTest.mdc line 144 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <10> but was: <0>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)

io.quarkus.vertx.mdc.VertxMDCTest.mdcNonVertxThreadTest line 121 - More details - Source on GitHub

java.lang.AssertionError: 

Expected: a collection containing "Test MDC value ### Test 1"

@manovotn
Copy link
Contributor Author

The failures are unrelated.

@manovotn manovotn merged commit 48d3265 into quarkusio:main May 18, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 18, 2023
@manovotn manovotn deleted the clientProxyWithFinalMethods branch May 18, 2023 15:01
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom cdi context not applied for certain bean types
3 participants