-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not attempt to detect container runtime in native-sources build #33368
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
.../deployment/src/main/java/io/quarkus/deployment/pkg/steps/NoopNativeImageBuildRunner.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package io.quarkus.deployment.pkg.steps; | ||
|
||
import java.nio.file.Path; | ||
import java.util.List; | ||
|
||
public class NoopNativeImageBuildRunner extends NativeImageBuildRunner { | ||
|
||
private static final String MESSAGE = "NoopNativeImageBuildRunner is not meant to be used to perform an actual build."; | ||
private final boolean isContainer; | ||
|
||
public NoopNativeImageBuildRunner(boolean isContainer) { | ||
this.isContainer = isContainer; | ||
} | ||
|
||
@Override | ||
public boolean isContainer() { | ||
return isContainer; | ||
} | ||
|
||
@Override | ||
protected String[] getGraalVMVersionCommand(List<String> args) { | ||
throw new UnsupportedOperationException(MESSAGE); | ||
} | ||
|
||
@Override | ||
protected String[] getBuildCommand(Path outputDir, List<String> args) { | ||
throw new UnsupportedOperationException(MESSAGE); | ||
} | ||
|
||
@Override | ||
protected void objcopy(Path outputDir, String... args) { | ||
throw new UnsupportedOperationException(MESSAGE); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it related to this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's from the documentation part talking about using
native-sources
. Testing this PR requires using that command.