Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not attempt to detect container runtime in native-sources build #33368

Merged
merged 2 commits into from
May 17, 2023
Merged

Do not attempt to detect container runtime in native-sources build #33368

merged 2 commits into from
May 17, 2023

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented May 15, 2023

Closes: #33161

@zakkak zakkak requested a review from yrodiere May 15, 2023 08:48
@zakkak zakkak marked this pull request as ready for review May 15, 2023 08:48
@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

gsmet
gsmet requested changes May 15, 2023
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunnerDummy.java Outdated Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunnerDummy.java Outdated Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildRunnerDummy.java Outdated Show resolved Hide resolved
docs/src/main/asciidoc/building-native-image.adoc
Comment on lines +789 to +793
--user $(id -ur):$(id -gr) \
--rm \
--v $(pwd):/work \# <1>
-v $(pwd):/work \# <1>
-w /work \# <2>
--entrypoint bin/sh \
--entrypoint /bin/sh \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it related to this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's from the documentation part talking about using native-sources. Testing this PR requires using that command.

@zakkak zakkak force-pushed the 2023-05-15-fix-33161 branch from dd34f09 to db9ffd7 Compare May 15, 2023 11:58
@quarkus-bot

This comment has been minimized.

Sign in to view
@gsmet
Copy link
Member

gsmet commented May 16, 2023

@zakkak the failures look related.

@quarkus-bot
Copy link

quarkus-bot bot commented May 16, 2023

Failing Jobs - Building 4bd0553

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/opentelemetry/deployment 
! Skipped: extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment extensions/quartz/deployment and 31 more

📦 extensions/opentelemetry/deployment

✖ io.quarkus.opentelemetry.deployment.instrumentation.GraphQLOpenTelemetryTest.nestedCdiBeanInsideQueryTraceTest line 133 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: Received: [SpanData{spanContext=ImmutableSpanContext{traceId=a5e294b6cd9f861c366bca05d8ee4fa0, spanId=dd7fcfe7b1bb1aa0, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, parentSpanContext=ImmutableSpanContext{traceId=a5e294b6cd9f861c366bca05d8ee4fa0, spanId=3d34eb587f21f44e, traceFlags=01, traceState=ArrayBasedTraceState{entries=[]}, remote=false, valid=true}, resource=Resource{schemaUrl=https://opentelemetry.io/schemas/1.19.0, attributes={service.name="quarkus-opentelemetry-deployment", service.version="999-SNAPSHOT", telemetry.sdk.language="java", telemetry.sdk.name="opentelemetry", telemetry.sdk.version="1.25.0", webengine.name="Quarkus", webengine.version="999-SNAPSHOT"}}, instrumentationScopeInfo=InstrumentationScopeInfo{name=io.quarkus.opentelemetry, version=null, schemaUrl=null, attributes={}}, name=CustomCDIBean.waitForSomeTime, kind=INTERNAL, startEpochNanos=1684251648947131600, endEpochNanos=16842516...

@zakkak
Copy link
Contributor Author

zakkak commented May 17, 2023 •
edited
Loading

The latest CI failure seems unrelated to me.

@zakkak zakkak requested a review from gsmet May 17, 2023 08:46
@gsmet gsmet merged commit aad9ce5 into quarkusio:main May 17, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 17, 2023
@gsmet gsmet modified the milestones: 3.2 - main, 3.1.0.Final May 23, 2023
@gsmet gsmet removed this from the 3.1.0.Final milestone May 23, 2023
@gsmet gsmet added this to the 3.0.4.Final milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand left review comments

@gsmet gsmet gsmet approved these changes

@yrodiere yrodiere Awaiting requested review from yrodiere

Assignees
No one assigned
Labels
area/core area/documentation area/kafka-streams kind/bugfix
Projects
None yet
Milestone
3.0.4.Final
Development

Successfully merging this pull request may close these issues.

Quarkus 3 quarkus.package.type=native-sources require docker/podman or native-image
3 participants
@zakkak @gsmet @geoand