Add a create-extension Maven mojo

[ppalaga]

No description provided.

[ppalaga]

cc @emmanuelbernard

[ppalaga]

Force pushed 1995478 with shorter file paths to make Windows happy.

This branch demonstrates how I'd like to use the mojo in camel-quarkus. (A similar setup can be done for the main Quarkus repo too.)

• The mojo is configured in extensions/pom.xml: ppalaga/camel-quarkus@8d8bf56#diff-93a993e25585d2f32e21d7c8ff6d8242R57
• This configuration contains all settings common to all future extensions in this repo and makes it possible to create new extensions by providing just a single parameter at the command line, e.g.:

mvn io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:create-extension -N -Dquarkus.artifactIdBase=log

• The result of running the above can be seen in ppalaga/camel-quarkus@33b5992

[Dufgui]

Very interesting feature. Thanks a lot. A really small return (maybe I am wrong):
you code most of the part inside the mojo itself and not put anything in devtools common. But it can be interesting to put in common the template part if someone code the graddle part. And you write directly inside the filesystem. And in this way you cannot write in a zip for exemple. You can reuse/extends ZipProjectWriter and FileProjectWriter no ? What do you think about it ?

[ppalaga]

you code most of the part inside the mojo itself and not put anything in devtools common. But it can be interesting to put in common the template part if someone code the graddle part.

Sorry, I am primarily addressing my own need and this is unfortunately of the scope. Somebody who finds this important is welcome to do that.

And you write directly inside the filesystem. And in this way you cannot write in a zip for exemple. You can reuse/extends ZipProjectWriter and FileProjectWriter no ? What do you think about it ?

The current proposal is just solving the task of creating extension modules in existing source trees. How would a zip file be useful in that scenario?

[Dufgui]

For the put in common ok. It s just a proposal to facility the gradle part.

I start to work on a web project generator. So I think it’s interesting to do the same on extension. But I am on hold and wait some return to progress again. So it’s up to you for the zip part.

[ppalaga]

web project generator. So I think it’s interesting to do the same on extension.

I see, but I guess zipping and being used from an online generator would only make sense for the standalone scenario, that I left unimplemented https://github.com/quarkusio/quarkus/pull/3191/files#diff-e41033b79bb31b53ffe8ec1f25646b7bR476

[aloubyansky]

BTW, it'd be also great to mention this in the guide. And as it's a noteworthy feature, I believe, @gsmet will appreciate a brief summary of it he could include in the release notes.
Thanks @ppalaga!

[ppalaga]

3442267:

• Rebased on current master
• Addressed some @aloubyansky 's comments

Still open from my PoV:

• How to handle the version of maven-compiler-plugin? - If document - where? If version - do we want a separate Mojo param?
• No problem with mentioning the new mojo in the guide, I vote for creating a followup issue and assigning to me.

[aloubyansky]

@ppalaga there were test failures, could you review those please? Thanks.

[ppalaga]

0ab6267 should fix the test failures

[ppalaga]

The CI is passing now

[ppalaga]

About 52ad079:

• Added requiresProject = false to @Mojo
• There is a basic autodetection of assumeManaged mojo param that controls whether the versions of deps and config of the bootstrap plugin is added: https://github.com/quarkusio/quarkus/pull/3191/files#diff-e41033b79bb31b53ffe8ec1f25646b7bR373
• Default template for the runtime module changed accordingly https://github.com/quarkusio/quarkus/pull/3191/files#diff-ead5e214bdd42168992f8277004cb379R22
• Added a general purpose utility to transform POM files while keeping the original formatting and comments: https://github.com/quarkusio/quarkus/pull/3191/files#diff-4c8d18606ed61dac84a0bb2870dccd66R36

All issues are solved from my PoV.

[ppalaga]

f957cc8 should fix the windows build

[ppalaga]

Is this good to merge now, @aloubyansky ?

[aloubyansky]

Looks great, thanks a lot @ppalaga !

[gsmet]

I removed the noteworthy-feature label for now because we don't have any documentation about this feature.

We need to have a paragraph in the extension guide explaining how this works.

[ppalaga]

@gsmet could you please assing #3386 to me?