-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer a quarkus create-extension Maven plugin command #2113
Comments
As @cescoffier said in the duplicate, I'm interested to work on this. |
One question, so far the extensions are part of the Quarkus source repo. The I had the discussion with @gsmet when doing the swagger extension, AFAIK there is no plan to have extensions hosted outisde the Quarkus repo. WFDYT? |
Hi @danielpetisme ,
That's not what I said. Right now, we don't have the infrastructure for that but having extensions outside our repo is something we want to encourage in the longer term. What would be nice is if the If not in the extensions directory, I would create an external extension in a new directory, without playing with the parent pom either. What will be interesting to see is how it interacts with a bom for extensions (we might want one for runtime - which could be the current bom - and one for deployment or one global if it makes more sense) and/or the need of a parent. See #2154. |
If we have to decide, I’d prefer we have the generator ready for extensions outside the core repo.
Emmanuel
… On 19 Apr 2019, at 15:07, Guillaume Smet ***@***.***> wrote:
Hi @danielpetisme ,
AFAIK there is no plan to have extensions hosted outisde the Quarkus repo
That's not what I said. Right now, we don't have the infrastructure for that but having extensions outside our repo is something we want to encourage in the longer term.
What would be nice is if the create-extension mojo could analyze if it's in the extensions directory (we can analyze the pom file) and adapt the created extension to the Quarkus environment. The issue with adding the extension to the pom is that it will reformat the file, which we don't really want. And extensions are categorized. So for now, I wouldn't do it. We could have a WARN message saying you need to add the extension in the pom.
If not in the extensions directory, I would create an external extension in a new directory, without playing with the parent pom either.
What will be interesting to see is how it interacts with a bom for extensions (we might want one for runtime - which could be the current bom - and one for deployment or one global if it makes more sense) and/or the need of a parent. See #2154.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I started hacking on a maven plugin that would primarily suit the use case of adding extensions in camel-quarkus. |
Hey @ppalaga is that really specific to Camel? My concern would be fragmenting the community by offering tools useful in different islands. Also ideally we don't want people to have to install / setup / know more than the Quarkus maven plugin. I understand we can't adhere to that stic tline 100%. I am just mentioning the general intent. |
No, what I have is not Camel only. I am aiming at adding extension modules to source trees similar to quarkus or camel-quarkus. Creating standalone extension projects is out of my scope now. I am adding the new mojo to |
The PR #3191 is ready for review. |
Fix #2113 create-extension Maven mojo
The idea is to simplify the extension creation path
The text was updated successfully, but these errors were encountered: