Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a quarkus create-extension Maven plugin command #2113

Closed
emmanuelbernard opened this issue Apr 16, 2019 · 8 comments
Closed

Offer a quarkus create-extension Maven plugin command #2113

emmanuelbernard opened this issue Apr 16, 2019 · 8 comments
Milestone

Comments

@emmanuelbernard
Copy link
Member

The idea is to simplify the extension creation path

@danielpetisme
Copy link
Contributor

As @cescoffier said in the duplicate, I'm interested to work on this.

@danielpetisme
Copy link
Contributor

danielpetisme commented Apr 19, 2019

One question, so far the extensions are part of the Quarkus source repo. The create-extension command should be preconfigured with the quarkus repo structure (+ register the extension in the build-parent pom/bom etc.) or it should permit to create an extension out side ?

I had the discussion with @gsmet when doing the swagger extension, AFAIK there is no plan to have extensions hosted outisde the Quarkus repo.

WFDYT?

@gsmet
Copy link
Member

gsmet commented Apr 19, 2019

Hi @danielpetisme ,

AFAIK there is no plan to have extensions hosted outisde the Quarkus repo

That's not what I said. Right now, we don't have the infrastructure for that but having extensions outside our repo is something we want to encourage in the longer term.

What would be nice is if the create-extension mojo could analyze if it's in the extensions directory (we can analyze the pom file) and adapt the created extension to the Quarkus environment. The issue with adding the extension to the pom is that it will reformat the file, which we don't really want. And extensions are categorized. So for now, I wouldn't do it. We could have a WARN message saying you need to add the extension in the pom.

If not in the extensions directory, I would create an external extension in a new directory, without playing with the parent pom either.

What will be interesting to see is how it interacts with a bom for extensions (we might want one for runtime - which could be the current bom - and one for deployment or one global if it makes more sense) and/or the need of a parent. See #2154.

@emmanuelbernard
Copy link
Member Author

emmanuelbernard commented Apr 19, 2019 via email

@ppalaga
Copy link
Contributor

ppalaga commented Jul 10, 2019

I started hacking on a maven plugin that would primarily suit the use case of adding extensions in camel-quarkus.

@emmanuelbernard
Copy link
Member Author

Hey @ppalaga is that really specific to Camel? My concern would be fragmenting the community by offering tools useful in different islands. Also ideally we don't want people to have to install / setup / know more than the Quarkus maven plugin.

I understand we can't adhere to that stic tline 100%. I am just mentioning the general intent.

@ppalaga
Copy link
Contributor

ppalaga commented Jul 10, 2019

No, what I have is not Camel only. I am aiming at adding extension modules to source trees similar to quarkus or camel-quarkus. Creating standalone extension projects is out of my scope now. I am adding the new mojo to devtools/maven module of the Quarkus repo. I hope I'll be able to send a PR soon.

ppalaga added a commit to ppalaga/quarkus that referenced this issue Jul 11, 2019
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jul 11, 2019
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jul 11, 2019
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jul 11, 2019
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jul 12, 2019
@ppalaga
Copy link
Contributor

ppalaga commented Jul 12, 2019

The PR #3191 is ready for review.

ppalaga added a commit to ppalaga/quarkus that referenced this issue Jul 15, 2019
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jul 19, 2019
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jul 23, 2019
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jul 23, 2019
aloubyansky added a commit that referenced this issue Jul 24, 2019
Fix #2113 create-extension Maven mojo
@gsmet gsmet changed the title Offer a quarkus create-extension maven and gradle plugin command Offer a quarkus create-extension Maven plugin command Jul 30, 2019
@gsmet gsmet added this to the 0.20.0 milestone Jul 30, 2019
Dufgui pushed a commit to Dufgui/quarkus that referenced this issue Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants