[2.13] - Backport Vert.x Metrics support #30420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s (including the one for the Vert.x SQL clients), Redis... The code is an adaptation of the Vert.x Micrometer pool metrics implementation to follow the Quarkus conventions.
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
quarkus-bot
bot
added
area/mailer
area/metrics
area/persistence
|
/cc @ebullient (micrometer) |
|
@gsmet Not sure I understand the "PR contains merge commits", it should not. |
|
What's a bit more concerning is that CI didn't run at all. There's something weird going on. Let me have a look. |
- Added Vert.x client metrics (as close as possible to the pool metrics) - Added TCP (Net) client metrics - Added TCP (Net) server metrics - Added UDP metrics - Added event bus metrics - Added HTTP client metrics - Do not monitor the REST client as it's already tracked using a Rest client filter - Configure the metric names of various Vert.x clients to get the data collected correctly - this include reactive DB drivers, redis... - Tags and metrics names are aligned with the existing ones
gsmet
force-pushed
the
vertx-metrics-backport
branch
from
e49c264 to
977e096
Compare
|
I think GitHub was in a weird state. I just amended the comment of the last commit and force pushed and everything is in order now and regular CI has started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport the Vert.x metrics support: