Add Vert.x pool metrics to Quarkus Micrometer #29805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ebullient |
3 tasks
This comment has been minimized.
This comment has been minimized.
|
I will look at the build issue, it might be related. |
Pool metrics cover Vert.x worker threads, the various connection pools (including the one for the Vert.x SQL clients), Redis... The code is an adaptation of the Vert.x Micrometer pool metrics implementation to follow the Quarkus conventions.
cescoffier
force-pushed
the
vertx-pool-metrics
branch
from
eec5371 to
31bfa0c
Compare
ebullient
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Vert.x pool metrics.
Pool metrics cover Vert.x worker threads, the various connection pools (including the one for the Vert.x SQL clients), and Redis...
The code is an adaptation of the Vert.x Micrometer pool metrics implementation to follow the Quarkus conventions.
Also, configure the Redis pool name properly.