Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ingress class name property part of Ingress config #30007

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Add ingress class name property part of Ingress config #30007

merged 1 commit into from
Jan 4, 2023

Conversation

Sgitario
Copy link
Contributor

Fix #29858

@Sgitario Sgitario requested a review from iocanel December 21, 2022 13:49
@Sgitario Sgitario mentioned this pull request Dec 21, 2022
Closed
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 21, 2022

Failing Jobs - Building 3f28a4b

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

@geoand
Copy link
Contributor

geoand commented Dec 23, 2022

@iocanel can you take a look at this one please?

iocanel
iocanel approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iocanel iocanel merged commit 0942a53 into quarkusio:main Jan 4, 2023
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Jan 4, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jan 4, 2023
@Sgitario Sgitario deleted the ingress_classname branch January 9, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
area/kubernetes kind/enhancement New feature or request
Projects
None yet
Milestone
2.16.0.CR1
Development

Successfully merging this pull request may close these issues.

Ability to set ingressClassName
3 participants
@Sgitario @geoand @iocanel