Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set ingressClassName #29858

Closed
kjq opened this issue Dec 14, 2022 · 8 comments · Fixed by #30007
Closed

Ability to set ingressClassName #29858

kjq opened this issue Dec 14, 2022 · 8 comments · Fixed by #30007
Labels
Milestone

Comments

@kjq
Copy link

kjq commented Dec 14, 2022

Description

It would be convenient and helpful to be able to set the ingressClassName on generated Kubernetes manifests.

Currently, we use the Quarkus Helm Extension to templatize that as a Helm chart but it does not add new properties only augments existing one. We work around this by having a /kubernetes/ingress.yml with just that property now.

This would help us in adopting the new ingress rules that can be set in the application.yml and remove the need for an additional configuration resource.

Implementation ideas

No response

@kjq kjq added the kind/enhancement New feature or request label Dec 14, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 14, 2022

/cc @Sgitario(kubernetes), @geoand(kubernetes), @iocanel(kubernetes)

@Sgitario
Copy link
Contributor

This needs to be done first in Dekorate: dekorateio/dekorate#1111

@kjq
Copy link
Author

kjq commented Dec 14, 2022

Hah, thanks for telling me - i was excited to pull down the codebase and try my hand at a PR.

Sgitario added a commit to Sgitario/dekorate that referenced this issue Dec 16, 2022
Sgitario added a commit to Sgitario/dekorate that referenced this issue Dec 16, 2022
iocanel pushed a commit to dekorateio/dekorate that referenced this issue Dec 16, 2022
@Sgitario
Copy link
Contributor

PR to update Dekorate to the latest version: #29926
After this is merged, we can add the new property in the Quarkus configuration.

@Sgitario
Copy link
Contributor

@kjq, after the mentioned pull request is merged, if you are interested in working on this, go ahead! :)

@Sgitario
Copy link
Contributor

FYI, @kjq , I've already provided a fix for this issue: #30007

@kjq
Copy link
Author

kjq commented Dec 21, 2022

@Sgitario - Thanks! It looks like I was on the right track comparing my changes to yours, i'll be ready now next time at least to submit a PR.

@Sgitario
Copy link
Contributor

Great!!

@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Jan 4, 2023
ebullient pushed a commit to maxandersen/quarkus that referenced this issue Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants