Enable more config providers for code generators except those found in the root app module #28538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/core
area/devtools
aloubyansky
force-pushed
the
codegen-config-fix
branch
from
dbdf819
to
6253b9f
Compare
aloubyansky
commented
Oct 12, 2022
| @@ -169,6 +171,47 @@ public static boolean trigger(ClassLoader deploymentClassLoader, | |||
| }); | |||
| } | |||
|
|
|||
| public static Config getConfig(ApplicationModel appModel, LaunchMode launchMode, Properties buildSystemProps, | |||
| QuarkusClassLoader deploymentClassLoader) throws CodeGenException { | |||
| // Config instance that is returned by this method should be as close to the one built in the ExtensionLoader as possible | |||
There was a problem hiding this comment.
@radcortez I tried to keep it as close to the ExtensionLoader one as I could
…n the root app module
aloubyansky
force-pushed
the
codegen-config-fix
branch
from
6253b9f
to
902e8e9
Compare
aloubyansky
changed the title
radcortez
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the config passed to the code generators is missing a lot of config sources compared to the original config built for the application. This change enables most of them except config providers found in the root application module because those haven't been compiled yet when running in dev mode.
This change also makes sure the
Configinstance is created once for all the providers and source paths, instead of number of providers * number of source paths.Fixes quarkiverse/quarkus-openapi-generator#131