Yaml configuration not honored.

[mike-hampton-float]

My configuration is in a yaml file.

My openapi file is here crm-svc/service/src/main/openapi/sellerdeal.yaml

My application.yaml file has

quarkus:
  openapi-generator:
    codegen:
      spec:
        sellerdeal_yaml:
          base-package:
            com.floatfin.sellerdeal.openapi

Expected

The generated interfaces have the package:

com.floatfin.sellerdeal.openapi;

Actual

The generated interfaces have the package:

package org.openapi.quarkus.sellerdeal_yaml.api;

[ricardozanini]

Hi @mike-hampton-float! Thanks for reporting it. I'll take a look.

[vladaman]

I have same issue. There is different behavior depending on how you run the generator.

1. mvn clean quarkus:generate-code doesn't honor configuration option and generates code with org.openapi.quarkus package
2. mvn clean compile generates code properly

[ricardozanini]

hmm, it might be a bug in Quarkus, then. Thanks for sharing @vladaman. I'll take a look later this week.

[ricardozanini]

By the way, @gastaldi @geoand, do you guys know or have you seen anything like this before?

[gastaldi]

No idea, but is this reproducible using application.properties too?

[ricardozanini]

No, using application.properties works. :(

[gastaldi]

It may indicate that the YAML ConfigSource is not found during quarkus:generate-code. WDYT @aloubyansky ?

[hbelmiro]

@gastaldi @aloubyansky

When the implementation of CodeGenProvider runs, the quarkus-config-yaml extension has not yet been loaded.

quarkus-openapi-generator/deployment/src/main/java/io/quarkiverse/openapi/generator/deployment/codegen/OpenApiGeneratorCodeGenBase.java

Line 52 in 98f70d2

this.generate(context.config(), openApiFilePath, outDir);

Would that be the expected behavior or a bug?

[aloubyansky]

It's a bug, imo. The yaml config source has been loaded by that time but the config instance passed to the code generator doesn't include it.
@radcortez this looks like a consequence of quarkusio/quarkus#21887 and quarkusio/quarkus@ff95ddf that resulted in https://github.com/quarkusio/quarkus/blob/main/core/deployment/src/main/java/io/quarkus/deployment/CodeGenerator.java#L156-L162 Could we do better here?

[aloubyansky]

It seems like we don't want to load config sources from the app module itself but do want to support those found in the dependencies (whether they belong to the same multi module project or not). We should be able to achieve that with classpath filtering.

[aloubyansky]

This is the idea aloubyansky/quarkus@309480d @radcortez am I missing something?

[radcortez]

Yes, commented on the commit :)

[ricardozanini]

Thanks guys!

[hbelmiro]

Thanks for the quick fix @aloubyansky and @radcortez.
However, this extension needs exactly the config that is in the root app, which is not contemplated in the fix.
I think there's a good reason for not existing a YAML alternative for ApplicationPropertiesConfigSourceLoader, but I'll ask anyway. Wouldn't it be possible to create a YamlPropertiesConfigSourceLoader to cover this use case?

[aloubyansky]

@hbelmiro do you have a config or a config provider impl? Unless it's the config provider, it should work. Is there a chance you could give it a try? You'd need to build the main branch of Quarkus. Let me know if you need help/instructions to do that.

[hbelmiro]

@aloubyansky I tried and it didn't work. I might have done something wrong though.

The scenario is the following:
The user creates a Quarkus app with a src/main/resources/application.yaml and the quarkus-openapi-generator dependency (this extension). During a mvn compile, this extension needs to read the config from application.yaml to perform its job.

Should it work?

[aloubyansky]

Yes. Do you have a reproducer ready to try?

[aloubyansky]

Do you have quarkus-config-yaml among the project's dependencies?

[hbelmiro]

I definitely did something wrong. It's not using Quarkus 999-SNAPSHOT.
I'll try again and if it doesn't work, I'll provide a reproducer.

Do you have quarkus-config-yaml among the project's dependencies?

Yes.

[hbelmiro]

@aloubyansky It worked. Sorry for wasting your time. Thanks for the help :)

@ricardozanini we can close this issue.

[aloubyansky]

Thanks for confirming @hbelmiro!