Fixes related to using public APIs introduced in GraalVM 22.3 #28316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zakkak
commented
Sep 30, 2022
zakkak
commented
- Fixes a class cast exception by actually loading the class and not just its name.
- Reduces the invocations to Version.getCurrent() in the generated native-image Feature
- Specifies (as required) the module name when registering jaxp resource bundles
|
@jerboaa can you please review? |
jerboaa
approved these changes
Sep 30, 2022
Comment on lines
187
to
+188
| tryBlock.invokeStaticMethod(registerLambdaCapturingClass, | ||
| tryBlock.load(i.getClassName())); | ||
| tryBlock.loadClassFromTCCL(i.getClassName())); |
There was a problem hiding this comment.
Right, this is fixing: https://github.com/graalvm/mandrel/actions/runs/3156296401/jobs/5136091100#step:11:316
OK.
Comment on lines
33
to
36
| void resourceBundles(BuildProducer<NativeImageResourceBundleBuildItem> resourceBundle) { | ||
| Consumer<String> resourceBundleItemProducer = bundleName -> resourceBundle | ||
| .produce(new NativeImageResourceBundleBuildItem(bundleName, "java.xml")); | ||
| Stream.of( |
There was a problem hiding this comment.
These changes are fixing: https://github.com/graalvm/mandrel/actions/runs/3156296401/jobs/5136091100#step:11:343, but we also need oracle/graal#5118 correct?
gsmet
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.