Avoid using internal API from package org.graalvm.nativeimage.impl
#28093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 20, 2022
zakkak
force-pushed
the
runtimeinitializationsupport-public-api
branch
2 times, most recently
from
2754c50 to
ceddfa0
Compare
|
The removal of the remaining usages requires upstream changes, see oracle/graal#5013. |
This comment has been minimized.
This comment has been minimized.
zakkak
force-pushed
the
runtimeinitializationsupport-public-api
branch
from
ceddfa0 to
930d0ab
Compare
This comment has been minimized.
This comment has been minimized.
|
@jerboaa can you please review this? |
jerboaa
suggested changes
Sep 28, 2022
extensions/awt/runtime/src/main/java/io/quarkus/awt/runtime/graal/DarwinAwtFeature.java
Outdated
Show resolved
Hide resolved
Stops using the internal methods from the `org.graalvm.nativeimage.impl` package.
Removes use of internal API
Since `RuntimeResourceAccess#addResourceBundle` requires a module to be passed to it we pass the unnamed module by default and extend `NativeImageResourceBundleBuildItem` to include a module name for specifying one when needed, e.g., for JDK internal resources.
zakkak
force-pushed
the
runtimeinitializationsupport-public-api
branch
from
930d0ab to
a5c2014
Compare
gsmet
pushed a commit
that referenced
this pull request
Sep 30, 2022
Fixes issues introduced in #28093
gsmet
pushed a commit
to gsmet/quarkus
that referenced
this pull request
Oct 3, 2022
Fixes issues introduced in quarkusio#28093 (cherry picked from commit ea67abe)
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this pull request
Oct 16, 2022
Fixes issues introduced in quarkusio#28093
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this pull request
Oct 16, 2022
Fixes issues introduced in quarkusio#28093
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this pull request
Oct 16, 2022
Fixes issues introduced in quarkusio#28093
igorregis
pushed a commit
to igorregis/quarkus
that referenced
this pull request
Oct 17, 2022
Fixes issues introduced in quarkusio#28093
tmihalac
pushed a commit
to tmihalac/quarkus
that referenced
this pull request
Oct 27, 2022
Fixes issues introduced in quarkusio#28093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #27728 (comment)