-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable tests which were failing on mac M1 in some timezones #28082
Re-enable tests which were failing on mac M1 in some timezones #28082
Conversation
Oh dear, we still have a failure (possibly several, but we will need to wait for the build report). I've checked and my branch definitely has #28044, so we either need to revisit #28044 or apply it to a test we missed.
|
This comment has been minimized.
This comment has been minimized.
…ericas, on Mac M1, in the CI." This reverts commit cca97bd.
94fe4a7
to
43bba01
Compare
I suspect this will fail and should not be merged without doing #28035, but triggering a build, so we will see. |
Failing Jobs - Building 43bba01
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 MacOS M1 #- Failing: integration-tests/hibernate-orm-graphql-panache integration-tests/jackson
📦 integration-tests/hibernate-orm-graphql-panache✖
📦 integration-tests/jackson✖
|
Closing for lack of activity. We can revisit if we end up adding M1 to CI. |
See discussion in #28044 and #28035 and #27156. The tests were failing, but should now be passing because of @geoand's quick fix.
(... but let's wait and see what the build does before merging.)