Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable tests which were failing on mac M1 in some timezones #28082

Closed

Conversation

holly-cummins
Copy link
Contributor

See discussion in #28044 and #28035 and #27156. The tests were failing, but should now be passing because of @geoand's quick fix.

(... but let's wait and see what the build does before merging.)

@quarkus-bot quarkus-bot bot added area/jackson Issues related to Jackson (JSON library) area/spring Issues relating to the Spring integration labels Sep 20, 2022
@holly-cummins
Copy link
Contributor Author

Oh dear, we still have a failure (possibly several, but we will need to wait for the build report). I've checked and my branch definitely has #28044, so we either need to revisit #28044 or apply it to a test we missed.

Error:  Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.586 s <<< FAILURE! - in io.quarkus.it.hibertnate.orm.graphql.panache.HibernateOrmGraphQLPanacheTest
Error:  io.quarkus.it.hibertnate.orm.graphql.panache.HibernateOrmGraphQLPanacheTest.testEndpoint  Time elapsed: 1.131 s  <<< FAILURE!
java.lang.AssertionError: 
1 expectation failed.
JSON path data.authors.dob doesn't match.
Expected: iterable containing ["1821-11-11"]
  Actual: <[1821-11-10]>

@holly-cummins holly-cummins marked this pull request as draft September 20, 2022 10:25
@quarkus-bot

This comment has been minimized.

…ericas, on Mac M1, in the CI."

This reverts commit cca97bd.
@holly-cummins holly-cummins force-pushed the reenable-datetime-tests branch from 94fe4a7 to 43bba01 Compare November 23, 2022 12:15
@holly-cummins holly-cummins marked this pull request as ready for review November 23, 2022 13:36
@holly-cummins
Copy link
Contributor Author

I suspect this will fail and should not be merged without doing #28035, but triggering a build, so we will see.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 23, 2022

Failing Jobs - Building 43bba01

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 17 MacOS M1 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 MacOS M1 #

- Failing: integration-tests/hibernate-orm-graphql-panache integration-tests/jackson 

📦 integration-tests/hibernate-orm-graphql-panache

io.quarkus.it.hibertnate.orm.graphql.panache.HibernateOrmGraphQLPanacheTest.testEndpoint line 63 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path data.authors.dob doesn't match.

📦 integration-tests/jackson

io.quarkus.it.jackson.DateDeserializerPojoResourceTest.testSqlDate line 42 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path date doesn't match.

@holly-cummins holly-cummins marked this pull request as draft December 14, 2022 16:43
@gsmet gsmet added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Feb 4, 2023
@gsmet
Copy link
Member

gsmet commented Oct 22, 2024

Closing for lack of activity. We can revisit if we end up adding M1 to CI.

@gsmet gsmet closed this Oct 22, 2024
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jackson Issues related to Jackson (JSON library) area/spring Issues relating to the Spring integration triage/invalid This doesn't seem right triage/needs-rebase This PR needs to be rebased first because it has merge conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants