-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MacOS M1 runs to incremental builds #27156
Conversation
This comment has been minimized.
This comment has been minimized.
Merging of this is paused pending adding the M1 runner, which is paused pending quarkusio/quarkus-github-bot#256. |
I've added an extra set of rules which leverage quarkusio/quarkus-github-bot#256 to control what PRs are allowed to run on the runners. This helps secure both the new M1 runner and the existing hosted runners. This should be ready to merge; if we get the sequencing wrong and merge too early, the worst consequence is that we start to build up a backlog of requests on the M1 runner. |
8c0e51f
to
ad72802
Compare
@holly-cummins have you seen the macOS build is pending? |
ad72802
to
a724ef3
Compare
This comment has been minimized.
This comment has been minimized.
a724ef3
to
0740842
Compare
I wasn't planning to enable the M1 runner until the repo workflows were locked down and bot configuration was pushed. To allow the timing of the two things to be more separate, I'll pull the bot configuration changes out into another PR. |
This comment has been minimized.
This comment has been minimized.
See #27899 for the bot changes, which should be merged first. |
This comment has been minimized.
This comment has been minimized.
0740842
to
033ddd7
Compare
79338f1
to
170f1d2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
501a410
to
6b4f85d
Compare
This comment has been minimized.
This comment has been minimized.
6b4f85d
to
88bba45
Compare
This comment has been minimized.
This comment has been minimized.
c068417
to
ccc6c44
Compare
This comment has been minimized.
This comment has been minimized.
ccc6c44
to
b06790d
Compare
This comment has been minimized.
This comment has been minimized.
b06790d
to
f9b403c
Compare
Another nearly clear run on M1: just this failure, which seems to me to be a brittle test. The output is the same as the expected, except for the order of parameters:
|
(I'll re-run to confirm the |
Same smallrye config failure on the next run, so I have disabled and raised #28057. |
a6ed521
to
14ee522
Compare
14ee522
to
a6ed521
Compare
Preprocess the matrix to avoid running M1 jobs on forks
…on Mac M1, in the CI. It may be all mac fails, but I have left the condition as is for ease of searching.
Also specify Mac OS Reverse disabling test Re-disable test
a6ed521
to
fe3b84d
Compare
The main action run, https://github.com/quarkusio/quarkus/actions/runs/3083733398 is clean, and ran M1. In the run on my fork, https://github.com/holly-cummins/quarkus/actions/runs/3083733139, there's a test failure on windows, but the important thing is that M1 was not run. (We want to run M1 on PRs, but we do not want to run M1 on forks, since forks are very unlikely to have a self-hosted M1 runner attached to them.) The changes include
|
I have set up a self-hosted runner on a Mac Mini which can now start running builds. Before this PR is merged, we will need to adjust the quarkus repository settings to wire in the runner.
As a first pass, I've added the runner to the JVM matrix in the incremental build.
I disabled some linux-specific steps which are not currently run on windows, so skipping them on mac should also be safe. (Although I wonder about the mongodb one, and whether we should find a platform-agnostic way to stop it if it leaks).
https://github.com/holly-cummins/quarkus/actions/runs/2798189377 has build output for my PR, on a runner I attached to my fork. The M1 build did not succeed, which isn't totally surprising because we know we have a range of issues on that platform (which is why we want an M1 build!). However, it got about as far as the ubuntu Java 17 build. Both seemed to fail in the first
extensions
test suite they ran.The M1 failure was in mongodb, which makes me a bit nervous that stopping mongo will be needed in some way, especially since self-hosted-runners don't run on a fresh machine each time. I think it might be helpful to iterate on that while the M1 facility is available, to start building up some coverage of how often we see failures and where else they are. For example, I'm surprised I didn't see #25230 in the Actions build.