-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation is not updated #27076
Documentation is not updated #27076
Conversation
See #26658 (comment) (cherry picked from commit c6d89f5)
(cherry picked from commit e660ee0)
(cherry picked from commit bccf79c)
Signed-off-by: Michal Maléř <[email protected]> (cherry picked from commit 14a528f)
(cherry picked from commit 19c620d)
(cherry picked from commit 7f6e5ad)
(cherry picked from commit 22e8d78)
Co-authored-by: Guillaume Smet <[email protected]> (cherry picked from commit 89f38ad)
(cherry picked from commit 053a39f)
…first Presumably the `preClientSendHandler` was added to support observability/telemetry but it has not been working. The `preClientSendHandler` was previosuly ordered _after_ the request filters but the telemetry is reported using a filter (e.g. `OpenTelemetryClientFilter`). Given that setup the client’s route template was not set on the context until after the telemeetry was reported. This simply rearranges the `preClientSendHandler` to run first, before any other handlers, including filters. (cherry picked from commit fc78635)
(cherry picked from commit 7fd3a7f)
Relates to: https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/QuarkusTestResourceLifecylceManager/near/289446358 Co-authored-by: Jérémie Bresson <[email protected]> (cherry picked from commit 5223145)
Originally reported at https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/Configure.20grpc-server.20port.20name/near/289568076 (cherry picked from commit a763f50)
(cherry picked from commit aa70206)
(cherry picked from commit cdf39a4)
(cherry picked from commit cab846d)
(cherry picked from commit 62632e4)
(cherry picked from commit 906ebcb)
Bumps [kotlinx-coroutines-bom](https://github.com/Kotlin/kotlinx.coroutines) from 1.6.3 to 1.6.4. - [Release notes](https://github.com/Kotlin/kotlinx.coroutines/releases) - [Changelog](https://github.com/Kotlin/kotlinx.coroutines/blob/master/CHANGES.md) - [Commits](Kotlin/kotlinx.coroutines@1.6.3...1.6.4) --- updated-dependencies: - dependency-name: org.jetbrains.kotlinx:kotlinx-coroutines-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit 2a29f64)
Signed-off-by: Phillip Kruger <[email protected]> (cherry picked from commit 48787de)
…he process id. Without, it takes the process id from the build time. (cherry picked from commit 5a34f3f)
(cherry picked from commit 45e4b63)
…e from contributing guide. Also: De-emphasise instructions for setting up DOCKER_HOST, make it clear Windows should work. Co-Authored-By: Jason T. Greene <[email protected]> Co-Authored-By: Guillaume Smet <[email protected]> (cherry picked from commit 078c44f)
Bumps `apicurio-registry.version` from 2.2.4.Final to 2.2.5.Final. Updates `apicurio-registry-client` from 2.2.4.Final to 2.2.5.Final - [Release notes](https://github.com/apicurio/apicurio-registry/releases) - [Commits](Apicurio/apicurio-registry@2.2.4.Final...2.2.5.Final) Updates `apicurio-registry-serdes-avro-serde` from 2.2.4.Final to 2.2.5.Final --- updated-dependencies: - dependency-name: io.apicurio:apicurio-registry-client dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.apicurio:apicurio-registry-serdes-avro-serde dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> (cherry picked from commit bffd538)
2.11.0 backports 1
(cherry picked from commit cffa072)
…e/password (cherry picked from commit e2e33be)
/cc @Sanne, @brunobat, @gsmet, @loicmathieu, @radcortez, @yrodiere |
The documentation on the website should match the source found in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is true that the documentation on the website is not up-to-date. @gsmet is it a known release problem?
EDIT: See for example https://github.com/quarkusio/quarkus/blob/2.11/docs/src/main/asciidoc/rabbitmq-dev-services.adoc#access-the-management-ui, that section is missing at https://quarkus.io/guides/rabbitmq-dev-services, despite being introduced in 2.11.0.CR1: 516230f
Regardless, this PR is not necessary as all the relevant changes have already been backported:
https://quarkus.io/guides/rabbitmq-dev-services and it misses the part about the Management UI as desribed here https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/rabbitmq-dev-services.adoc#access-the-management-ui
It's already in 2.11: https://github.com/quarkusio/quarkus/blob/2.11/docs/src/main/asciidoc/rabbitmq-dev-services.adoc#access-the-management-ui
https://quarkus.io/guides/databases-dev-services misses the new part about how to connect to the database as described here https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/databases-dev-services.adoc#connect-to-database-run-as-a-dev-service
It's already in 2.11: https://github.com/quarkusio/quarkus/blob/2.11/docs/src/main/asciidoc/databases-dev-services.adoc#connect-to-database-run-as-a-dev-service
Side note: I think the new feature introduced during #25289 misses any mention in the docu?! Maybe the new command property should be explained with an example on https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/databases-dev-services.adoc ? Right now it is rather hard to find in the Configuration Reference section...
As you pointed out, the configuration property is documented in the configuration reference. The argument "it's hard to find" is hardly valid: if we accepted it, it would only lead to adding a section about every single configuration property, regardless of how exotic/rarely used it is, and then what's the point of the configuration reference? We can only reasonably add a section for the most important properties; I can't personally say whether this one is important enough, but others will probably chime in.
In any case, that's unrelated to the problem at hand: please open a separate issue/pull request so that you can have that discussion.
Though obviously it's not in 2.11, but that's the same problem as the other pieces of documentation.
The documentation publication script got broken here: 086c7bb#diff-d00c67fd13e9b811f6decf2a12b17ab690e3ff209c5712331d631d739c1a6657R12 . Thanks for raising the issue, I will republish everything. But this PR is doing nothing good. Closing it. |
Hello,
there is a difference between the latest public docu and the content of the
.adoc
files on github.For instance I checked
So I assume the docu in general was not updated?
Side note: I think the new feature introduced during #25289 misses any mention in the docu?! Maybe the new
command
property should be explained with an example on https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/databases-dev-services.adoc ? Right now it is rather hard to find in the Configuration Reference section.../update
I messed up the branch selection during PR creation. Sorry about that.