-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable custom postgres config in devservice #25289
Enable custom postgres config in devservice #25289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I added a couple of suggestions.
I'm not sure about the split of the guide but yeah maybe it makes sense.
But could you make the changes in two seperate commits of this PR as they are really unrelated (if you don't feel comfortable doing that with git
, I can do it and keep your authorship).
...c/main/java/io/quarkus/devservices/postgresql/deployment/PostgresqlDevServicesProcessor.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/quarkus/devservices/postgresql/deployment/PostgresqlDevServicesProcessor.java
Outdated
Show resolved
Hide resolved
4c226e0
to
32ee911
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a closer look at this one and setCommand()
is coming from GenericContainer
so it is supported by all the databases.
Thus I think it should be made a global config and not part of this container properties thing.
Let's wait until #25530 is in. Then it should be easier to add an Optional<String> command
to the config and consume it in all the *DevServicesProcessor
.
I am not sure if I got you correctly here. You are right that If all database support it (or in general the user should have more controll over the dev startup) a global config sounds very good. +1 |
Well, you're not adding parameters to the database, you're changing the command used to start the container, be it for PostgreSQL or the others. |
Right, this is what I said. Just wanted to raise my concern about the statement
|
Ah OK, I misunderstood what you said. My point is that even if you cannot push config parameters, well, it's optional so you're not forced to use it. And you might have other reasons to override the command. I think it's better than introducing something specific to PostgreSQL given it's a general thing. |
32ee911
to
b7108b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks. Sorry for the delay in reviewing!
I missed a way to configure Postgres in dev services. So far it is only possible for MariaDB/MySQL. So I added a similar approach.
Additionally, the dev services docu is scattered in quiet a lot of places. I created a new common page. similar to the other (much simpler) dev services. This is more or less independent from the code change - except for the added config example for postgres.