Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Dev Services for Infinispan Client IT and enforce Hibernate Search constraint in BOM #26647

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jul 11, 2022

Dragging the server via a test resource was problematic as the server requires a specific version of Hibernate Search.
Now that we have Dev Services for Infinispan, we can use them in the Infinispan IT module.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/infinispan Infinispan labels Jul 11, 2022
@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 11, 2022
@yrodiere
Copy link
Member

So this was really just the test setup, there is no backwards incompatibility caused by the Search 6.0 => 6.1 upgrade at all in the end.

Thanks for taking care of this, @gsmet!

@quarkus-bot

This comment has been minimized.

Copy link
Member

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! thanks @gsmet

Copy link
Member

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I just saw this error on the HealthCheck

java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.infinispan.client.deployment.devservices.InfinispanDevServiceProcessor#startInfinispanContainers threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image

is

Copy link
Member

@karesti karesti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet the code is ok but I'm just wondering what happened with the healthcheck test that failed and if is just normal

@aloubyansky
Copy link
Member

@karesti if you are curious about the original issue, it was found that (a part of) Infinispan was incompatible with Hibernate Search included in Quarkus #26565 (comment)
This PR is a workaround to avoid using the Infinispan server and Hibernate Search in the same runtime for the test.

@gsmet gsmet force-pushed the ispn-dev-services branch from 844ee96 to 80e1abc Compare July 20, 2022 09:09
@gsmet gsmet force-pushed the ispn-dev-services branch from 80e1abc to e647753 Compare July 20, 2022 09:10
@gsmet
Copy link
Member Author

gsmet commented Jul 20, 2022

Issue fixed, let's wait for CI.

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 20, 2022

Failing Jobs - Building e647753

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
JVM Tests - JDK 18 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main line 14 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ JVM Tests - JDK 18 #

- Failing: extensions/hibernate-search-orm-elasticsearch/deployment integration-tests/elasticsearch-rest-client integration-tests/elasticsearch-rest-high-level-client and 1 more
! Skipped: extensions/hibernate-search-orm-coordination-outbox-polling/deployment integration-tests/devmode integration-tests/hibernate-search-orm-elasticsearch and 3 more

📦 extensions/hibernate-search-orm-elasticsearch/deployment

Failed to execute goal io.fabric8:docker-maven-plugin:0.40.1:start (docker-start) on project quarkus-hibernate-search-orm-elasticsearch-deployment: I/O Error

📦 integration-tests/elasticsearch-rest-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.40.1:start (docker-start) on project quarkus-integration-test-elasticsearch-rest-client: I/O Error

📦 integration-tests/elasticsearch-rest-high-level-client

Failed to execute goal io.fabric8:docker-maven-plugin:0.40.1:start (docker-start) on project quarkus-integration-test-elasticsearch-rest-high-level-client: I/O Error

📦 integration-tests/logging-gelf

Failed to execute goal io.fabric8:docker-maven-plugin:0.40.1:start (docker-start) on project quarkus-integration-test-logging-gelf: I/O Error

@gsmet gsmet merged commit d3b6187 into quarkusio:main Jul 20, 2022
@quarkus-bot quarkus-bot bot added this to the 2.12 - main milestone Jul 20, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/infinispan Infinispan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants