-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Dev Services for Infinispan Client IT and enforce Hibernate Search constraint in BOM #26647
Conversation
So this was really just the test setup, there is no backwards incompatibility caused by the Search 6.0 => 6.1 upgrade at all in the end. Thanks for taking care of this, @gsmet! |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me! thanks @gsmet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I just saw this error on the HealthCheck
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.infinispan.client.deployment.devservices.InfinispanDevServiceProcessor#startInfinispanContainers threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image
is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gsmet the code is ok but I'm just wondering what happened with the healthcheck test that failed and if is just normal
@karesti if you are curious about the original issue, it was found that (a part of) Infinispan was incompatible with Hibernate Search included in Quarkus #26565 (comment) |
Issue fixed, let's wait for CI. |
Failing Jobs - Building e647753
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 18 #- Failing: extensions/hibernate-search-orm-elasticsearch/deployment integration-tests/elasticsearch-rest-client integration-tests/elasticsearch-rest-high-level-client and 1 more
! Skipped: extensions/hibernate-search-orm-coordination-outbox-polling/deployment integration-tests/devmode integration-tests/hibernate-search-orm-elasticsearch and 3 more 📦 extensions/hibernate-search-orm-elasticsearch/deployment✖ 📦 integration-tests/elasticsearch-rest-client✖ 📦 integration-tests/elasticsearch-rest-high-level-client✖ 📦 integration-tests/logging-gelf✖ |
Dragging the server via a test resource was problematic as the server requires a specific version of Hibernate Search.
Now that we have Dev Services for Infinispan, we can use them in the Infinispan IT module.