Added more relevant constraints to the quarkus-bom #26565

aloubyansky · 2022-07-05T15:42:56Z

No description provided.

aloubyansky · 2022-07-05T16:35:13Z

@gsmet I added wildfly-elytron-* and bitbucket after talking to @sberyozkin

gsmet · 2022-07-05T20:27:44Z

bom/application/pom.xml

@@ -14,6 +14,7 @@
    <packaging>pom</packaging>

    <properties>
+        <bitbucket.version>0.7.12</bitbucket.version>


This one probably needs to be added to Dependabot? Or put together with the dependencies that need alignment if it needs to be aligned (together with comments indicating the need for alignment).

@sberyozkin I added a direct dependency on jose4j to the module using its API directly. So it is both a direct dependency and a transitive dependency through io.smallrye:smallrye-jwt-build. Would you like to control it in the quarkus-bom or use whatever smallrye-jwt-build depends on? In the later case, perhaps we shouldn't add it to the BOM, unless you think the probability of conflicts will be high. smallrye-jwt-build is already managed, so if it comes only as a dependency of smallrye-jwt-build there won't be a problem if don't add it to the BOM.

@gsmet @sberyozkin I removed jose4j from this PR for now. Let's handle it separately from the rest.

aloubyansky · 2022-07-06T19:18:10Z

The Infinispan client's HealthCheckTest is failing because it's not compatible with the Hibernate Search version we are using including in our BOM. It works with 6.0.8, while the version we are including is 6.1.5.

quarkus-bot · 2022-07-06T23:18:02Z

Failing Jobs - Building `deda35b`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17
✔️	JVM Tests - JDK 18

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/mongodb-client/deployment 
! Skipped: extensions/liquibase-mongodb/deployment extensions/panache/mongodb-panache-common/deployment extensions/panache/mongodb-panache-kotlin/deployment and 8 more

📦 extensions/mongodb-client/deployment

✖ io.quarkus.mongodb.NamedMongoClientConfigTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration

✖ io.quarkus.mongodb.NamedReactiveMongoClientConfigTest. - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.mongodb.deployment.DevServicesMongoProcessor#startMongo threw an exception: java.lang.RuntimeException: java.lang.IllegalStateException: Previous attempts to find a Docker environment failed. Will not retry. Please see logs and check configuration

gsmet · 2022-07-07T05:37:30Z

bom/application/pom.xml

+                <groupId>org.hibernate.search</groupId>
+                <artifactId>hibernate-search-util-common</artifactId>
+                <version>${hibernate-search.version}</version>
+            </dependency>


@yrodiere could you have a look at this when you're back? It looks like we cannot enforce Hibernate Search's version properly when using Infinispan.

See this comment specifically: #26565 (comment)

@gsmet wdyt about merging it a figuring out the hibernate-search/infinispan compatibility separately? Given that the rest of the constraints aren't related to that.

@gsmet I can have a look but I'm not sure what I can do? The version of Infinispan bundled with Quarkus hasn't been updated to HSearch 6.1 yet. Infinispan's main branch has been upgraded, but I don't think it's been published yet.

The only immediate solutions I see are:

Upgrading to a newer version of Infinispan; not sure there is one.

Downgrading Hibernate Search; that doesn't seem wise.

Accepting we won't have matching versions. And that people can't use both Infinispan embedded and the Hibernate Search extension in the same application.

In the future, there are a few possible strategies, none of them great:

Accepting we won't have matching versions. And that people can't use both Infinispan embedded and the Hibernate Search extension in the same application.

Never breaking any SPI in Hibernate Search, ever again.

Waiting for Inifinispan to be released whenever we upgrade Hibernate Search, before upgrading in Quarkus.

Shading Hibernate Search into Infinispan Embedded.

Personally I'd favor 4. It's really supposed to be an internal dependency of Infinispan after all, since they're working hard on hiding all Hibernate Search APIs.

Last time I checked there wasn't a more recent Infinispan version for us to upgrade to, unfortunately.

Never breaking the SPI (2) is a great one :) And if you do, a safe way would be to coordinate releases, so that there is combination of Hibernate Search and Infinispan that works, which is (3).

Shading is an option, although it may complicate CVE tracking and patch delivery. But maybe not that much.

As to how wise downgrading the HS version is, it depends on how often people will run into this issue, basically how critical it is to have a working combination of the two. I am not sure for long it has been broken and whether anybody has run into it yet.

Despite all the complications, we shouldn't just let it go neither. Today we could document it as not being supported. Until one day we get one or more important use-cases that require both HS and Infinispan being present in the same app, at that moment we'll have to make it work somehow and starting from that moment, we will want to preserve compatibility and not have random breakages between releases. So thinking/preparing for that moment could be worth it.

@gsmet I don't think the rest of the changes should be blocked by this issue. Would you prefer to remove the comments I added about the HS/Infinispan issue from the BOM?

Nope, I will merge it, I was busy on other things.

not have random breakages between releases

It's not random, it's when necessary, on minor versions, in SPIs only, and that's a clearly established policy for all Hibernate projects. Let's not assume we're breaking stuff just because we don't care: we do :)

The exact reason we're having a problem is I'd been told in the past that there would not be any Infinispan Embedded in Quarkus, and since the HotRod (non-Embedded) client does not depend on Hibernate Search, the Hibernate Search dependency shouldn't have affected it at all.

So thinking/preparing for that moment could be worth it.

Certainly.

I'm back from PTO, so I'll be able to look further. First step would be to determine why the Hibernate Search dependency affects Infnispan at all; I thought Infinispan Embedded had been added to Quarkus without my knowledge, but that doesn't seem to be the case? It seems the error is really just in the HotRod client, which shouldn't be depending on Hibernate Search in the first place. I'll look into that.

What should I do to reproduce the issue; just uncomment those lines, build the relevant modules and run Quarkus + Infinispan integration tests?

Today we could document it as not being supported

Sure, documenting would be a good temporary solution.

Yes, to reproduce uncomment the constraints and run io.quarkus.it.infinispan.client.HealthCheckTest.testHealthCheck, you can see the failures from the CI above. Thanks!

Thanks.

For future reference, the problem was in the test dependencies rather than in the "main" dependencies. Guillaume addressed it here: #26647

quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Jul 5, 2022

gsmet approved these changes Jul 5, 2022

View reviewed changes

aloubyansky force-pushed the bom-additions branch from 1da9688 to 612524a Compare July 5, 2022 16:34

quarkus-bot bot added the area/oidc label Jul 5, 2022

gsmet requested changes Jul 5, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

aloubyansky force-pushed the bom-additions branch from 612524a to 88c213a Compare July 6, 2022 08:38

This comment has been minimized.

Sign in to view

aloubyansky force-pushed the bom-additions branch from 88c213a to 59afbb0 Compare July 6, 2022 08:49

gsmet approved these changes Jul 6, 2022

View reviewed changes

gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 6, 2022

mamadaliev approved these changes Jul 6, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

Added more relevant constraints to the quarkus-bom

deda35b

aloubyansky force-pushed the bom-additions branch from 59afbb0 to deda35b Compare July 6, 2022 19:16

gsmet reviewed Jul 7, 2022

View reviewed changes

gsmet merged commit 8f7accd into quarkusio:main Jul 7, 2022

quarkus-bot bot added this to the 2.11 - main milestone Jul 7, 2022

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 7, 2022

aloubyansky mentioned this pull request Jul 11, 2022

Use Dev Services for Infinispan Client IT and enforce Hibernate Search constraint in BOM #26647

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added more relevant constraints to the quarkus-bom #26565

Added more relevant constraints to the quarkus-bom #26565

aloubyansky commented Jul 5, 2022

aloubyansky commented Jul 5, 2022

gsmet Jul 5, 2022

aloubyansky Jul 5, 2022

aloubyansky Jul 6, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

aloubyansky commented Jul 6, 2022

quarkus-bot bot commented Jul 6, 2022

gsmet Jul 7, 2022

gsmet Jul 7, 2022

aloubyansky Jul 7, 2022

yrodiere Jul 7, 2022

aloubyansky Jul 7, 2022

aloubyansky Jul 7, 2022

gsmet Jul 7, 2022

yrodiere Jul 11, 2022

aloubyansky Jul 11, 2022

yrodiere Jul 11, 2022

Added more relevant constraints to the quarkus-bom #26565

Added more relevant constraints to the quarkus-bom #26565

Conversation

aloubyansky commented Jul 5, 2022

aloubyansky commented Jul 5, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

aloubyansky commented Jul 6, 2022

quarkus-bot bot commented Jul 6, 2022

Failing Jobs - Building deda35b

Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/mongodb-client/deployment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Failing Jobs - Building `deda35b`