Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resteasy Reactive Links: Improve "rel" deduction rules #25493

Merged
merged 2 commits into from
May 11, 2022

Conversation

Sgitario
Copy link
Contributor

@Sgitario Sgitario commented May 11, 2022

  • The new deduction logic is based on what Resteasy Classic (see table in section 8.2.4) is doing:
      • list for GET methods returning a Collection.
      • self for GET methods returning a non-Collection.
      • remove for DELETE methods.
      • update for PUT methods.
      • add for POST methods.
      • Otherwise, the rest method name.

This is a follow-up action from this comment: #25217 (comment)

- The new deduction logic is based on what Resteasy Classic is doing:
     * - `list` for GET methods returning a Collection.
     * - `self` for GET methods returning a non-Collection.
     * - `remove` for DELETE methods.
     * - `update` for PUT methods.
     * - `add` for POST methods.
     * - Otherwise, the rest method name.
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 11, 2022
@geoand geoand merged commit 8f01ea6 into quarkusio:main May 11, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 11, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label May 11, 2022
@Sgitario Sgitario deleted the rr_links_rel_good branch May 12, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants