Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Resteasy Reactive Links #25217

Merged
merged 1 commit into from
May 4, 2022
Merged

Conversation

Sgitario
Copy link
Contributor

Added documentation for resteasy reactive links.

Note that I haven't added any feature on top of the existing resteasy reactive links, only documentation, javadocs, and cosmetic changes in code.

@Sgitario
Copy link
Contributor Author

Sgitario commented Apr 28, 2022

Possible next actions:
1.- Add support for HAL types: this is already supported by Reactive REST data panache and we could bring this functionality into the resteasy reactive links with little effort (but I'm not sure if we can avoid some duplication... ): #25396
2.- Improve the rel values in RestLink. At the moment, if not set, it will use the method name. However, I think we could be smarter here to use the same convention than in resteasy classic (see table in section 8.2.4). #25493
3.- It was hard for me to understand the concepts of TYPE and INSTANCE in RestLinkType. And after seeing the comments from the original pull request, I read that it was also confused. From my point of view, we should get rid of it and just infer the usage of TYPE and INSTANCE by the response type.

What do you think about these future actions? If you agree with them, I can create separate issues for each one.

cc @geoand

Added documentation for resteasy reactive links.
@geoand
Copy link
Contributor

geoand commented Apr 28, 2022

They all sound very reasonable to me.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Is it ready to get merged?

@geoand
Copy link
Contributor

geoand commented May 3, 2022

I'll check soon

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks a lot @Sgitario!

@geoand geoand merged commit 96e2a75 into quarkusio:main May 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.10 - main milestone May 4, 2022
@Sgitario Sgitario deleted the doc_rr_links branch May 4, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants