Prepend http.root-path to permission paths without '/' #25181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be safe for 2.9.0.CR1 |
ebullient
reviewed
Apr 26, 2022
|
Hi @ebullient These editorial updates are very welcome, thanks |
sberyozkin
force-pushed
the
security_policy_path_with_http_root
branch
from
ddfb47c to
c7b1280
Compare
ebullient
approved these changes
Apr 26, 2022
ebullient
added
the
triage/waiting-for-ci
|
Thanks, |
Failing Jobs - Building c7b1280
Failures⚙️ Native Tests - Data2 #- Failing: integration-tests/jpa-oracle
📦 integration-tests/jpa-oracle✖ |
|
I think it is good to go |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to #25154, it does what I did for 2.8.1 then reverted for 2.8.2, in a better non-breaking way as recommended by Erin.
I will follow up with another PR where I'll go through various OIDC paths carefully and see if the same logic can be applied.