-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate how to have all Quarkus Security path properties prepended with quarkus.http.root-path #25154
Comments
Well, we also have |
Comment from @knutwannheden re option 1 is here. Indeed it was a breaking change in 2.8.1 so good it was reverted for 2.8.2 (if it makes it before the release). |
From what I understand from https://quarkus.io/blog/path-resolution-in-quarkus/ the configured paths will be relative to some context-dependent path if they don't start with a slash. Whenever they start with a slash they will be absolute (i.e. not even relative to the HTTP root). I think that would probably also work well for the paths configured with |
As I commented at #25155, these security related paths are URL path components, I see no point in introducing a notion of absolute paths in the context of dealing with these paths. |
Absolute vs relative to For example, if a user configures then has to work with |
Erin @ebullient has educated me more about this idea of absolute vs relative paths, and I think I'm getting it. So if it is |
Yes. Apparently I did a poor job of explaining myself 😅 |
Sounds great! |
Description
vertx-http
,oidc
,keycloak-authorization
and possibly other security extensions have some endpoint paths configured, security policy paths, various OIDC code flow paths, etc.When these paths are checked,
quarkus.http.root-path
is not taken into consideration internally.We should try to find the best approach how to do it.
Currently the users can do it by prepending
${quarkus.http.root-path}
to the specific path, for example:Implementation ideas
quarkus.oidc.root
set toquarkus.http.root-path
by default and users can override it if necessaryThe text was updated successfully, but these errors were encountered: