Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus-oidc: logout.path does not honor root-path #25045

Closed
mschorsch opened this issue Apr 20, 2022 · 5 comments
Closed

quarkus-oidc: logout.path does not honor root-path #25045

mschorsch opened this issue Apr 20, 2022 · 5 comments
Labels
area/oidc kind/bug Something isn't working

Comments

@mschorsch
Copy link
Contributor

Describe the bug

If the quarkus.http.root-path is changed, this is not taken into account when specifying quarkus.oidc.logout.path.

see also #24728

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

Java 11

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.8.1.Final

Build tool (ie. output of mvnw --version or gradlew --version)

Maven

Additional information

No response

@mschorsch mschorsch added the kind/bug Something isn't working label Apr 20, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 20, 2022

/cc @pedroigor, @sberyozkin

@mschorsch
Copy link
Contributor Author

@sberyozkin Can you take a look in this issue. This seems to be a similar case as #24728. Thanks.

@sberyozkin
Copy link
Member

sberyozkin commented Apr 25, 2022

@mschorsch I'm not sure how to address this issue yet, CodeAuthenticationMechanism has many different paths, and I'm starting doubting if a fix for #24728 was correct and instead paths should be configured with ${quarkus.http.root-path} prefixes when necessary, instead of individual extensions (apart from Vert.x HTTP and various /q handlers taking care of http.root.path).

It needs to be discussed more

@sberyozkin
Copy link
Member

@mschorsch I'm sorry but I'm going to close this issue for now. Please prepend ${http.root.path} to the path related properties to retain a flexibility to keep switching to different root paths including a default "/" value.
I agree it is less ideal compared to ${quarkus.http.root-path} being added internally but I'm worried it can start a chain effect of causing different migration issues.

I've also opened #25144 to revert the #24728 fix - it is my fault I have not thought it through carefully.

I've also started a discussion at https://groups.google.com/g/quarkus-dev/c/_5QU2yMxHCw, you are welcome to contribute to it. Perhaps we can work out a simple uniform mechanism to make the prepending happening under the hood across all the extensions similarly to what David Lloyd suggests.

@sberyozkin
Copy link
Member

@mschorsch I've opened an issue to track it, #25154, I'm not sure when I'll look at it, but it will be tracked, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/oidc kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants