Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix REST Client Reactive path handling for sub-resources #25131

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fix REST Client Reactive path handling for sub-resources #25131

merged 1 commit into from
Apr 25, 2022

Conversation

michalszynkiewicz
Copy link
Member

fixes #25028

@michalszynkiewicz
Copy link
Member Author

cc @Sgitario

@michalszynkiewicz
Copy link
Member Author

This change:

  • cleans up the way the targets for subresources are created,
  • fixes generating the close() method,
  • fixed selecting converters for parameters,
  • gets rid of unnecessarily generated code in methods that return subresources

@gsmet
Copy link
Member

gsmet commented Apr 25, 2022

@geoand @michalszynkiewicz it looks like a big change to backport to 2.8 but... given this thing is very broken and I suppose the standard cases are well covered by tests, maybe we should do it?

@michalszynkiewicz
Copy link
Member Author

@geoand @michalszynkiewicz it looks like a big change to backport to 2.8 but... given this thing is very broken and I suppose the standard cases are well covered by tests, maybe we should do it?

Especially that the problem also impacts the keycloak admin client #24991

@michalszynkiewicz michalszynkiewicz merged commit 6d057ee into quarkusio:main Apr 25, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 25, 2022
@michalszynkiewicz michalszynkiewicz mentioned this pull request Apr 25, 2022
Closed
@gsmet gsmet modified the milestones: 2.9 - main, 2.8.2.Final Apr 25, 2022
@rsvoboda
Copy link
Member

https://issues.redhat.com/browse/QUARKUS-2034 ... thus 2.7 backport label

@gsmet gsmet modified the milestones: 2.8.2.Final, 2.7.6.Final May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/rest kind/bugfix
Projects
None yet
Milestone
2.7.6.Final
Development

Successfully merging this pull request may close these issues.

Reactive REST client duplicates paths, described by subresources
4 participants
@michalszynkiewicz @gsmet @rsvoboda @geoand