Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactive REST client duplicates paths, described by subresources #25028

Closed
fedinskiy opened this issue Apr 20, 2022 · 13 comments · Fixed by #25131
Closed

Reactive REST client duplicates paths, described by subresources #25028

fedinskiy opened this issue Apr 20, 2022 · 13 comments · Fixed by #25131
Assignees
Labels
area/rest-client kind/bug Something isn't working
Milestone

Comments

@fedinskiy
Copy link
Contributor

Describe the bug

When reactive REST client is used to access sub-resources of some HTTP resource, it duplicates paths which describe these sub-resources. For example, if there is such method in rest client:

@Path("/resource")
public interface Client {
 @Path("/sub")
    SubClient getSubResource()
 }
}

then call client.getSubResource().getSomething() will lead to HTTP request to resource/sub/sub/something.

Expected behavior

Sub-resources should not lead to duplicated paths.

Actual behavior

Paths are duplicated

How to Reproduce?

  1. git clone -b reproducer/duplicate-paths [email protected]:fedinskiy/quarkus-test-suite.git
  2. cd http/rest-client-reactive
  3. mvn clean verify -Dit.test=ReactiveRestClientIT#deepLevel ( or ReactiveRestClientIT#subResource)
  4. There is a log which shows, that requests are send to URLs like http://localhost:1101/books/author/profession/profession/wage/wage/currency/currency/name

Output of uname -a or ver

5.16.13-200.fc35.x86_64

Output of java -version

11.0.12, vendor: GraalVM Community

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.7.5.Final

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)

Additional information

No response

@fedinskiy fedinskiy added the kind/bug Something isn't working label Apr 20, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 20, 2022

/cc @michalszynkiewicz

@geoand
Copy link
Contributor

geoand commented Apr 21, 2022

@michalszynkiewicz can you take a look at this please?
As @sberyozkin mentions, this is likely causing problems with the Keycloak admin client

@michalszynkiewicz michalszynkiewicz self-assigned this Apr 21, 2022
@michalszynkiewicz
Copy link
Member

I'll try to fix this today

@michalszynkiewicz
Copy link
Member

it turned out to be slightly more complex than anticipated but I should be able to fix it tomorrow :)

@ghost
Copy link

ghost commented Apr 25, 2022

Hi, any news? I am troubled by this problem. When can it be fixed? @michalszynkiewicz

@geoand
Copy link
Contributor

geoand commented Apr 25, 2022

Michal is working on it. It will be fixed soon (in 2.8.3 at the earliest). That's as specific as we can be.

@ghost
Copy link

ghost commented Apr 25, 2022

Michal is working on it. It will be fixed soon (in 2.8.3 at the earliest). That's as specific as we can be.

2.8.3, how long will it take? I'm developing a project. If it takes too long, I can't wait for 2.8.3. I may need to solve the problem in another way.

@geoand
Copy link
Contributor

geoand commented Apr 25, 2022

There is no exact date.
Could be next week or the week after

@ghost
Copy link

ghost commented Apr 25, 2022

Great! I see it has been fixed! It will be added to next version 2.8.2, right? And, when 2.8.2 will be released?@geoand

@geoand
Copy link
Contributor

geoand commented Apr 25, 2022

It's unlikely to make it into 2.8.2 (which may be in the process of being released)

@gsmet
Copy link
Member

gsmet commented Apr 25, 2022

I will release 2.8.2 tomorrow. This patch will be in if it's merged by this evening.

@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 25, 2022
@gsmet gsmet modified the milestones: 2.9 - main, 2.8.2.Final Apr 25, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 25, 2022
@ghost
Copy link

ghost commented Apr 27, 2022

I see 2.8.2 released, great! I love quarkus! Great team! Great quarkus!

@geoand
Copy link
Contributor

geoand commented Apr 27, 2022

🥰

@gsmet gsmet modified the milestones: 2.8.2.Final, 2.7.6.Final May 24, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue May 24, 2022
fedinskiy added a commit to fedinskiy/quarkus-test-suite that referenced this issue Jun 3, 2022
fedinskiy added a commit to fedinskiy/quarkus-test-suite that referenced this issue Jun 3, 2022
fedinskiy added a commit to fedinskiy/quarkus-test-suite that referenced this issue Jun 6, 2022
fedinskiy added a commit to fedinskiy/quarkus-test-suite that referenced this issue Jun 6, 2022
fedinskiy added a commit to fedinskiy/quarkus-test-suite that referenced this issue Jun 8, 2022
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this issue Jun 14, 2022
quarkusio/quarkus#24402
quarkusio/quarkus#24405
quarkusio/quarkus#24415
quarkusio/quarkus#25028
Additionally: delete temporary files to speed up local execution
(cherry picked from commit 565a6fd)
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this issue Jun 14, 2022
quarkusio/quarkus#24402
quarkusio/quarkus#24405
quarkusio/quarkus#24415
quarkusio/quarkus#25028
Additionally: delete temporary files to speed up local execution
(cherry picked from commit 565a6fd)
fedinskiy added a commit to quarkus-qe/quarkus-test-suite that referenced this issue Jun 14, 2022
quarkusio/quarkus#24402
quarkusio/quarkus#24405
quarkusio/quarkus#24415
quarkusio/quarkus#25028
Additionally: delete temporary files to speed up local execution
(cherry picked from commit 565a6fd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rest-client kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants