Prevent buildpack inception style builds #24995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
geoand
reviewed
Apr 19, 2022
| @@ -42,6 +42,7 @@ | |||
| public class BuildpackProcessor { | |||
|
|
|||
| private static final Logger log = Logger.getLogger(BuildpackProcessor.class); | |||
| private static final String IN_BUILDPACK_BUILD = "IN_BUILDPACK_BUILD"; | |||
There was a problem hiding this comment.
Would it not make more sense to have an enabled field in BuildpackConfig?
There was a problem hiding this comment.
I think you are right, we should use real configuration properties.
I am learning towards reusing quarkus.container-image.build=false and quarkus.container-image.push=false as this does not require us to introduce new properties.
gsmet
changed the title
iocanel
force-pushed
the
issue23613-inception-style-buildpack
branch
from
951d9db to
e79bfbe
Compare
geoand
approved these changes
Apr 22, 2022
iocanel
force-pushed
the
issue23613-inception-style-buildpack
branch
from
e79bfbe to
f167a85
Compare
This comment has been minimized.
This comment has been minimized.
mamadaliev
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #23613
The pull request adds an environmental variable in the build, which when present prevents a nested build from taking place.