Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the split package in the gRPC extension artifacts #24817

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Get rid of the split package in the gRPC extension artifacts #24817

merged 1 commit into from
Apr 7, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Apr 7, 2022

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/grpc gRPC labels Apr 7, 2022
@michalszynkiewicz
Copy link
Member

so io.quarkus.grpc is in the api, io.quarkus.grpc.stubs in stubs and io.quarkus.grpc.runtime in the extension's runtime?

@mkouba
Copy link
Contributor Author

mkouba commented Apr 7, 2022

so io.quarkus.grpc is in the api, io.quarkus.grpc.stubs in stubs and io.quarkus.grpc.runtime in the extension's runtime?

Exactly!

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 7, 2022
@cescoffier
Copy link
Member

Thanks!

@Sanne Sanne merged commit 51843c0 into quarkusio:main Apr 7, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 7, 2022
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalszynkiewicz michalszynkiewicz michalszynkiewicz approved these changes

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/grpc gRPC kind/enhancement New feature or request
Projects
None yet
Milestone
2.9.0.CR1
Development

Successfully merging this pull request may close these issues.

Get rid of the split package in the gRPC extension artifacts
4 participants
@mkouba @michalszynkiewicz @cescoffier @Sanne