Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the split package in the gRPC extension artifacts #21919

Closed
mkouba opened this issue Dec 3, 2021 · 4 comments · Fixed by #24817
Closed

Get rid of the split package in the gRPC extension artifacts #21919

mkouba opened this issue Dec 3, 2021 · 4 comments · Fixed by #24817
Assignees
Labels
area/grpc gRPC kind/enhancement New feature or request
Milestone

Comments

@mkouba
Copy link
Contributor

mkouba commented Dec 3, 2021

Description

The package in question is the package io.quarkus.grpc and the artifacts are quarkus-grpc-stubs and quarkus-grpc.

Implementation ideas

No response

@mkouba mkouba added the kind/enhancement New feature or request label Dec 3, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 3, 2021

/cc @cescoffier, @michalszynkiewicz

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Dec 3, 2021
@gsmet gsmet added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jan 1, 2022
@gsmet
Copy link
Member

gsmet commented Jan 1, 2022

I think it should probably be put on the radar for 2.8. @cescoffier @michalszynkiewicz I don't know if you have a gRPC roadmap somewhere?

@cescoffier
Copy link
Member

gRPC is part of the reactive roadmap. However we don't have this issue on it. We can definitely add it.

@mkouba
Copy link
Contributor Author

mkouba commented Apr 7, 2022

FTR there's actually another package that needs to be fixed: io.quarkus.grpc.runtime.

I think that we should:

  1. Extract the classes from the io.quarkus.grpc package into the quarkus-grpc-api artifact.
  2. Rename the io.quarkus.grpc.runtime package in the quarkus-grpc-stubs artifact to io.quarkus.grpc.stubs. This change should not break anything because io.quarkus.grpc.runtime is not part of the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc gRPC kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants