Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sending query params as using a Map in Reactive Rest Client #24783

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Add support for sending query params as using a Map in Reactive Rest Client #24783

merged 1 commit into from
Apr 6, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Apr 6, 2022

Resolves: #24764

@geoand geoand requested a review from michalszynkiewicz April 6, 2022 05:11
@geoand geoand changed the title Add support for sending multiple query params as using a Map Add support for sending query params as using a Map Apr 6, 2022
@quarkus-bot quarkus-bot bot added the area/rest label Apr 6, 2022
@geoand geoand changed the title Add support for sending query params as using a Map Add support for sending query params as using a Map in Reactive Rest Client Apr 6, 2022
michalszynkiewicz
michalszynkiewicz reviewed Apr 6, 2022
View reviewed changes
.../src/main/java/io/quarkus/jaxrs/client/reactive/deployment/JaxrsClientReactiveProcessor.java
if (componentType == null) {
componentType = DotNames.OBJECT.toString();
if (isMap(type, index)) {
var resolvesTypes = resolveMapTypes(type, index, jandexMethod);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a note, usage of Map.Entry here feels weird to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally use it all the time because Java doesn't have something like Tuple2. If you want, I can replace it with a custom class

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, no need to replace it. Maybe some day we could add some simplistic smallrye project, or something inside Quarkus, that would have tuples.

@geoand geoand merged commit 98db0e4 into quarkusio:main Apr 6, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Apr 6, 2022
@geoand geoand deleted the #24764 branch April 6, 2022 07:57
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Apr 6, 2022
@gsmet gsmet modified the milestones: 2.9 - main, 2.8.2.Final Apr 25, 2022
@gsmet gsmet modified the milestones: 2.8.2.Final, 2.7.6.Final May 24, 2022
@kdubb kdubb mentioned this pull request May 31, 2022
Merged
michalvavrik added a commit to michalvavrik/quarkus-test-suite that referenced this pull request Jun 15, 2022
@michalvavrik
Test Reactive Rest Client support of dynamic number of query parameters
3133ad8 
Reactive Rest Client newly supports ([Quarkus PR 24783](quarkusio/quarkus#24783)) passing a query parameters as a map. This is very useful when user don't know query parameters in advance. Feature details can be found in a [TP here](quarkus-qe/quarkus-test-plans#82). Test covers situation when query parameters are of primitive type, Java class or an array (supported by `MultivaluedMap`) and more than one formal parameter is annotated with `@RestQuery`.
@michalvavrik michalvavrik mentioned this pull request Jun 15, 2022
Merged
8 tasks
michalvavrik added a commit to michalvavrik/quarkus-test-suite that referenced this pull request Jun 15, 2022
@michalvavrik
Test Reactive Rest Client support of dynamic number of query parameters
447402e 
Reactive Rest Client newly supports ([Quarkus PR 24783](quarkusio/quarkus#24783)) passing a query parameters as a map. This is very useful when user don't know query parameters in advance. Feature details can be found in a [TP here](quarkus-qe/quarkus-test-plans#82). Test covers situation when query parameters are of primitive type, Java class or an array (supported by `MultivaluedMap`) and more than one formal parameter is annotated with `@RestQuery`.
fedinskiy pushed a commit to quarkus-qe/quarkus-test-suite that referenced this pull request Jun 16, 2022
@michalvavrik @fedinskiy
Test Reactive Rest Client support of dynamic number of query parameters
5d592c7 
Reactive Rest Client newly supports ([Quarkus PR 24783](quarkusio/quarkus#24783)) passing a query parameters as a map. This is very useful when user don't know query parameters in advance. Feature details can be found in a [TP here](quarkus-qe/quarkus-test-plans#82). Test covers situation when query parameters are of primitive type, Java class or an array (supported by `MultivaluedMap`) and more than one formal parameter is annotated with `@RestQuery`.
pjgg pushed a commit to pjgg/quarkus-test-suite that referenced this pull request Jun 16, 2022
@michalvavrik
Test Reactive Rest Client support of dynamic number of query parameters
2fd196c 
Reactive Rest Client newly supports ([Quarkus PR 24783](quarkusio/quarkus#24783)) passing a query parameters as a map. This is very useful when user don't know query parameters in advance. Feature details can be found in a [TP here](quarkus-qe/quarkus-test-plans#82). Test covers situation when query parameters are of primitive type, Java class or an array (supported by `MultivaluedMap`) and more than one formal parameter is annotated with `@RestQuery`.

(cherry picked from commit 5d592c7)
michalvavrik added a commit to michalvavrik/quarkus that referenced this pull request Jun 16, 2022
@michalvavrik
Document Reactive Rest Client support of dynamic query parameters
a6fc895 
Documents: [24783](quarkusio#24783)

Reactive Rest Client sending query paramters passed as a `Map`, however I can't see this in documentation. There should be at least reference to this feature.
@michalvavrik michalvavrik mentioned this pull request Jun 16, 2022
Merged
michalvavrik added a commit to michalvavrik/quarkus that referenced this pull request Jun 16, 2022
@michalvavrik
Document Reactive Rest Client support of dynamic query parameters
3e583d5 
Documents: [24783](quarkusio#24783)

Reactive Rest Client sending query paramters passed as a `Map`, however I can't see this in documentation. There should be at least reference to this feature.
michalvavrik added a commit to michalvavrik/quarkus that referenced this pull request Jun 16, 2022
@michalvavrik
Document Reactive Rest Client support of dynamic query parameters
95157c5 
Documents: [24783](quarkusio#24783)

Reactive Rest Client sending query paramters passed as a `Map`, however I can't see this in documentation. There should be at least reference to this feature.
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Jun 21, 2022
@michalvavrik @gsmet
Document Reactive Rest Client support of dynamic query parameters
c773634 
Documents: [24783](quarkusio#24783)

Reactive Rest Client sending query paramters passed as a `Map`, however I can't see this in documentation. There should be at least reference to this feature.

(cherry picked from commit 95157c5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalszynkiewicz michalszynkiewicz michalszynkiewicz approved these changes

Assignees
No one assigned
Labels
area/rest kind/enhancement New feature or request
Projects
None yet
Milestone
2.7.6.Final
Development

Successfully merging this pull request may close these issues.

Allow us to configure dynamic query parameters in the rest client
3 participants
@geoand @michalszynkiewicz @gsmet