Test Reactive Rest Client support of dynamic number of query parameters #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedinskiy
requested changes
Jun 15, 2022
...-client-reactive/src/main/java/io/quarkus/ts/http/restclient/reactive/PlainBookResource.java
Outdated
Show resolved
Hide resolved
...-client-reactive/src/main/java/io/quarkus/ts/http/restclient/reactive/PlainBookResource.java
Outdated
Show resolved
Hide resolved
...client-reactive/src/main/java/io/quarkus/ts/http/restclient/reactive/json/BookIdWrapper.java
Show resolved
Hide resolved
Reactive Rest Client newly supports ([Quarkus PR 24783](quarkusio/quarkus#24783)) passing a query parameters as a map. This is very useful when user don't know query parameters in advance. Feature details can be found in a [TP here](quarkus-qe/quarkus-test-plans#82). Test covers situation when query parameters are of primitive type, Java class or an array (supported by `MultivaluedMap`) and more than one formal parameter is annotated with `@RestQuery`.
michalvavrik
force-pushed
the
feature/rest-query-for-reactive-client
branch
from
3133ad8 to
447402e
Compare
michalvavrik
added
the
triage/backport-2.7?
|
Good points, thanks for the review. |
fedinskiy
approved these changes
Jun 16, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reactive Rest Client newly supports (Quarkus PR 24783) passing a query parameters as a map. This is very useful when user don't know query parameters in advance. Feature details can be found in a TP here. Test covers situation when query parameters are of primitive type, Java class or an array (supported by
MultivaluedMap) and more than one formal parameter is annotated with@RestQuery.Please select the relevant options.
Checklist: