Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow control of resume on 404 behavior via build item #24672

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Allow control of resume on 404 behavior via build item #24672

merged 1 commit into from
Mar 31, 2022
+17 −4

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 31, 2022

Relates to: #24671

@geoand geoand requested a review from ia3andy March 31, 2022 14:22
ia3andy
ia3andy approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

It looks good code wise, sorry, I can't try it before coming back from PTO.

FroMage
FroMage approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@FroMage FroMage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Mar 31, 2022
@geoand geoand merged commit b010b61 into quarkusio:main Mar 31, 2022
@quarkus-bot quarkus-bot bot added this to the 2.9 - main milestone Mar 31, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 31, 2022
@geoand geoand deleted the #24671 branch April 1, 2022 05:52
@gsmet gsmet modified the milestones: 2.9 - main, 2.8.1.Final Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

@FroMage FroMage FroMage approved these changes

Assignees
No one assigned
Labels
area/rest
Projects
None yet
Milestone
2.8.1.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@geoand @FroMage @ia3andy @gsmet