Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to control resume on 404 behavior from other extensions with RESTEasy classic #24671

Closed
ia3andy opened this issue Mar 31, 2022 · 5 comments
Assignees

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Mar 31, 2022

Description

In the experimental Quinoa extension, in dev mode, I need a behavior where my Handler catches everything that isn't successfully handled by other extensions. The idea is that all those not found requests should be forwarded to a node dev server.

Currently, RESTEasy Reactive has a flag for it:
https://github.com/quarkusio/quarkus/blob/main/extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment/src/main/java/io/quarkus/resteasy/reactive/server/deployment/ResteasyReactiveProcessor.java#L808
This flag is only available for servlet capability.

I would like to make it possible for any extension (using a BuildItem?) to enable resumeOn404.

Also, I wonder why we don't always resume on 404 and put the resteasy 404 mapper handler far down the priority list so that other can plug in their handler the middle of the vertx router priority queue, without needing such an option. Ex:

  • /hello -> handled by resteasy
  • /some-file-> passed to the next by resteasy, passed to the next by quinoa, 404 handling by resteasy
  • /index.html -> passed to the next by resteasy, handled by quinoa
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 31, 2022

/cc @FroMage, @geoand, @stuartwdouglas

@ia3andy
Copy link
Contributor Author

ia3andy commented Mar 31, 2022

I am not sure if the issue is the same, but mentioning as it's similar: #5236

@geoand
Copy link
Contributor

geoand commented Mar 31, 2022

I am only going to do for RESTEasy Reactive.

@geoand geoand self-assigned this Mar 31, 2022
geoand added a commit to geoand/quarkus that referenced this issue Mar 31, 2022
geoand added a commit that referenced this issue Mar 31, 2022
Allow control of resume on 404 behavior via build item
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 11, 2022
@geoand
Copy link
Contributor

geoand commented Jan 27, 2023

Should we close this as we have done the work for RESTEasy Reactive?

@ia3andy ia3andy added the triage/wontfix This will not be worked on label Jan 30, 2023
@ia3andy
Copy link
Contributor Author

ia3andy commented Jan 30, 2023

Let's close this issue for now as fixing this in RESTEasy Classic would involve too much effort.

@ia3andy ia3andy closed this as completed Jan 30, 2023
@ia3andy ia3andy changed the title Make it possible to resume on 404 instead of mapping with RESTEasy classic and reactive Not possible to control resume on 404 behavior from other extensions with RESTEasy classic Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants