Change RotationConfig defualtmax file size in FileConfig.java

[VanillaSpoon]

This is a continuation of #24060 as I accidentally removed the fork, which closed the pr.

###Change RotationConfig default max file size in FileConfig.java

---

In FileConfig.java RotationConfig the default value for Max Size of the log file after which a rotation is executed was set incorrectly.

---

Fixes #24041

[machi1990]

lgtm

[gsmet]

I'm still a bit nervous about this one. I think it warrants a discussion on the list about what should be the default behavior.

Given we had a FileHandler before, I think the rotation was entirely disabled. So it's not just about changing a default value, it's about enabling the rotation by default or not.

And enabling rotation at the Quarkus level could lead to very weird behaviors if an external log rotation is already in place.

[machi1990]

I'm still a bit nervous about this one. I think it warrants a discussion on the list about what should be the default behavior.

Given we had a FileHandler before, I think the rotation was entirely disabled. So it's not just about changing a default value, it's about enabling the rotation by default or not.

And enabling rotation at the Quarkus level could lead to very weird behaviors if an external log rotation is already in place.

Looking at #24060 (comment) from @jamezp, the SizeRotatingFileHandler which we are now defaulting too has better cleanups. But I do not see what weird behaviours the change could lead if we default to using that. It would good to see what are those.
If we default to enabling rotation, users can still opt out of rotation by setting the property to empty i.e

quarkus.log.handler.file."file-handlers".rotation.max-file-size=

That can be documented in the migration guide.

One other alternative as evoked in #24041 (comment) if we do not want to default to rotating the log file, is to document the default upstream behaviour via the defaultValueDocumentation knob. But the issue with that is we'll need to track upstream updates to make sure if the default changes there, we update the value for defaultValueDocumentation.

Or add a enable-rotation knob which controls if rotation is enabled or disable and not having to rely on the Optional max file size config.

[machi1990]

Closing as this is superseded by #25072