Change RotationConfig default max file size in FileConfig.java

[VanillaSpoon]

Change RotationConfig default max file size in FileConfig.java

---

In FileConfig.java RotationConfig the default value for Max Size of the log file after which a rotation is executed was set incorrectly

---

-@ConfigItem(defaultValueDocumentation = "10")
+@ConfigItem(defaultValue = "10M")

---

Fixes #24041

[machi1990]

/lgtm

Thanks for the quick PR @VanillaSpoon 🥄

[VanillaSpoon]

Thanks @machi1990 😊

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 60c50ae

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: core/test-extension/deployment 
! Skipped: integration-tests/test-extension 

📦 core/test-extension/deployment

✖ io.quarkus.logging.CategoryConfiguredHandlerTest.consoleOutputTest line 41 - More details - Source on GitHub

java.lang.AssertionError: 
[Extracted: class] 
Expecting actual:

---

⚙️ JVM Tests - JDK 11 Windows #

- Failing: core/test-extension/deployment 
! Skipped: integration-tests/test-extension 

📦 core/test-extension/deployment

✖ io.quarkus.logging.CategoryConfiguredHandlerTest.consoleOutputTest line 41 - More details - Source on GitHub

java.lang.AssertionError: 
[Extracted: class] 
Expecting actual:

---

⚙️ JVM Tests - JDK 17 #

- Failing: core/test-extension/deployment 
! Skipped: integration-tests/test-extension 

📦 core/test-extension/deployment

✖ io.quarkus.logging.CategoryConfiguredHandlerTest.consoleOutputTest line 41 - More details - Source on GitHub

java.lang.AssertionError: 
[Extracted: class] 
Expecting actual:

[machi1990]

Thanks @machi1990 blush

There are some tests failing. Can you have a look?

[VanillaSpoon]

Of course 😊 I'll get back to you @machi1990

[machi1990]

Of course blush I'll get back to you @machi1990

Thanks, let me know if you'll need some inputs.

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 89559ea

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: core/test-extension/deployment 
! Skipped: integration-tests/test-extension 

📦 core/test-extension/deployment

✖ io.quarkus.logging.CategoryConfiguredHandlerTest.consoleOutputTest line 41 - More details - Source on GitHub

java.lang.AssertionError: 
[Extracted: class] 
Expecting actual:

---

⚙️ JVM Tests - JDK 11 Windows #

- Failing: core/test-extension/deployment 
! Skipped: integration-tests/test-extension 

📦 core/test-extension/deployment

✖ io.quarkus.logging.CategoryConfiguredHandlerTest.consoleOutputTest line 41 - More details - Source on GitHub

java.lang.AssertionError: 
[Extracted: class] 
Expecting actual:

---

⚙️ JVM Tests - JDK 17 #

- Failing: core/test-extension/deployment 
! Skipped: integration-tests/test-extension 

📦 core/test-extension/deployment

✖ io.quarkus.logging.CategoryConfiguredHandlerTest.consoleOutputTest line 41 - More details - Source on GitHub

java.lang.AssertionError: 
[Extracted: class] 
Expecting actual:

[gsmet]

Hmmm, so I worked on fixing the tests and AFAICS, log rotation was disabled until now or at least it was not using a size rotating appender.

I think enabling rotation by default makes sense.

@jamezp do you see any red flags with this change?

[jamezp]

@gsmet Seems fine to me. The only question I'd have is if you'd prefer to default to a SizeRotatingFileHandler or a PeriodicRotatingFileHandler. The size one has better cleanup capabilities. However, it should be noted with the RotationConfig.fileSuffix of a date the files will NOT be deleted. You'll end up with no files being deleted on the next rotation.

[VanillaSpoon]

Sorry for not getting this one sorted guys. Thanks for the change @gsmet

[machi1990]

@gsmet Seems fine to me. The only question I'd have is if you'd prefer to default to a SizeRotatingFileHandler or a PeriodicRotatingFileHandler. The size one has better cleanup capabilities. However, it should be noted with the RotationConfig.fileSuffix of a date the files will NOT be deleted. You'll end up with no files being deleted on the next rotation.

+1 on defaulting to using SizeRotatingFileHandler.