Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only start Elasticsearch Dev Services for Hibernate Search if the default backend is in use #24012

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Only start Elasticsearch Dev Services for Hibernate Search if the default backend is in use #24012

merged 2 commits into from
Feb 28, 2022

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere requested a review from loicmathieu February 28, 2022 15:27
@yrodiere yrodiere mentioned this pull request Feb 28, 2022
Merged
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2022 •
edited
Loading

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building b9d44e5

Status Name Step Failures Logs Raw logs
✖ Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/hibernate-search-orm-elasticsearch/deployment 
! Skipped: docs extensions/hibernate-search-orm-coordination-outbox-polling/deployment integration-tests/devmode and 4 more

📦 extensions/hibernate-search-orm-elasticsearch/deployment

✖ Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-hibernate-search-orm-elasticsearch-deployment: File '/home/runner/work/quarkus/quarkus/extensions/hibernate-search-orm-elasticsearch/deployment/src/main/java/io/quarkus/hibernate/search/orm/elasticsearch/HibernateSearchElasticsearchProcessor.java' has not been previously formatted. Please format file and commit before running validation!

@yrodiere yrodiere force-pushed the no-es-dev-services-when-only-named-hsearch-backend branch from b9d44e5 to 9a3e3cc Compare February 28, 2022 15:53
loicmathieu
loicmathieu approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gsmet gsmet merged commit 2261afc into quarkusio:main Feb 28, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 28, 2022
@yrodiere yrodiere deleted the no-es-dev-services-when-only-named-hsearch-backend branch May 31, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

Assignees
No one assigned
Labels
area/elasticsearch area/hibernate-search Hibernate Search
Projects
None yet
Milestone
2.8.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@yrodiere @loicmathieu @gsmet