Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using Elasticsearch Dev Services by multiple extensions #23974

Merged

Conversation

loicmathieu
Copy link
Contributor

@loicmathieu loicmathieu commented Feb 25, 2022

Fixes #23904

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 25, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not end up with dot

This message is automatically generated by a bot.

@loicmathieu loicmathieu changed the title Allow using Elasticsearch Dev Services by multiple extensions. Allow using Elasticsearch Dev Services by multiple extensions Feb 25, 2022
@loicmathieu loicmathieu force-pushed the elasticsearch-devservices-improvement branch from 7d36539 to 402e887 Compare February 25, 2022 15:44
@loicmathieu loicmathieu requested a review from yrodiere February 25, 2022 15:44
@loicmathieu loicmathieu marked this pull request as ready for review February 25, 2022 15:44
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 25, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 402e887

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/elasticsearch-rest-client-common/deployment 
! Skipped: docs extensions/elasticsearch-rest-client/deployment extensions/elasticsearch-rest-high-level-client/deployment and 9 more

📦 extensions/elasticsearch-rest-client-common/deployment

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.1:validate (default) on project quarkus-elasticsearch-rest-client-common-deployment: File '/home/runner/work/quarkus/quarkus/extensions/elasticsearch-rest-client-common/deployment/src/main/java/io/quarkus/elasticsearch/restclient/common/deployment/DevServicesElasticsearchProcessor.java' has not been previously formatted. Please format file and commit before running validation!

@loicmathieu loicmathieu force-pushed the elasticsearch-devservices-improvement branch from 402e887 to f91c34d Compare February 25, 2022 16:09
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yrodiere yrodiere merged commit b0429fc into quarkusio:main Feb 28, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 28, 2022
@loicmathieu
Copy link
Contributor Author

One thing that bother me is if at the Hibernate Search side there is no usage of the default backend but multiple other one. We will start a container.
Maybe we need to check if the default backend exists and no default backend defined don't generate the build item.

@yrodiere
Copy link
Member

Maybe we need to check if the default backend exists and no default backend defined don't generate the build item.

Right, done: #24012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elasticsearch dev-services when multiple extensions use Elasticsearch
2 participants