Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set target dir in QuarkusUnitTest #23859

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

aloubyansky
Copy link
Member

It looks the target dir is missing in QuarkusUnitTest.
This is related to #23759 and #23856

@geoand
Copy link
Contributor

geoand commented Feb 22, 2022

We should probably backport this, right?

@aloubyansky
Copy link
Member Author

Yes

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 22, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 5679770

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/smallrye-openapi/deployment 
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 143 more

📦 extensions/smallrye-openapi/deployment

io.quarkus.smallrye.openapi.test.jaxrs.OpenApiStaticModelsTestCase.testMultipleStaticFiles line 33 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path paths.'/openapi'.get.operationId doesn't match.

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/smallrye-openapi/deployment 
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 143 more

📦 extensions/smallrye-openapi/deployment

io.quarkus.smallrye.openapi.test.jaxrs.OpenApiStaticModelsTestCase.testMultipleStaticFiles line 33 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path paths.'/openapi'.get.operationId doesn't match.

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/smallrye-openapi/deployment 
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 143 more

📦 extensions/smallrye-openapi/deployment

io.quarkus.smallrye.openapi.test.jaxrs.OpenApiStaticModelsTestCase.testMultipleStaticFiles line 33 - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path paths.'/openapi'.get.operationId doesn't match.

@geoand
Copy link
Contributor

geoand commented Feb 22, 2022

@phillip-kruger mind taking a look at the OpenAPI failures?

Thanks

@aloubyansky
Copy link
Member Author

The CI failures are caused by this change.

@geoand
Copy link
Contributor

geoand commented Feb 22, 2022

Yeah, just wondering if the tests themselves (or the OpenAPI extension) are making some incorrect assumption

@aloubyansky
Copy link
Member Author

I pushed a kind of fix to the SmallRyeOpenApiProcessor.java, which needs to be reviewed.

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@geoand geoand merged commit 7b574cd into quarkusio:main Feb 23, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 23, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.3.Final Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants