Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set output directry in case of outputDirectory in OutputBuildTargetItem is null #23856

Closed
wants to merge 1 commit into from

Conversation

AkMo3
Copy link
Contributor

@AkMo3 AkMo3 commented Feb 22, 2022

@aloubyansky
Copy link
Member

The proposed fix should probably become the main logic. I looked into why the output dir is missing in the original issue and #23859 should fix it. Although the way we are locating the build/target dir in other places is kind of a hack.

@aloubyansky
Copy link
Member

We should look into utilizing the ApplicationModel to set up all the paths when we bootstrap for tests though.

@AkMo3
Copy link
Contributor Author

AkMo3 commented Feb 22, 2022

We should look into utilizing the ApplicationModel to set up all the paths when we bootstrap for tests though.

Yeah. Any rough idea how we can do this, I would be happy to contribute.
Also, I guess we should close this PR now as it would be redundant after #23859

@aloubyansky
Copy link
Member

I was thinking we could actually initialize some of these paths (in case they haven't been set) from the ApplicationModel (existing or resolved) in the QuarkusBootstrap. It might not end up being a quick fix though.

@AkMo3
Copy link
Contributor Author

AkMo3 commented Feb 22, 2022

I was thinking we could actually initialize some of these paths (in case they haven't been set) from the ApplicationModel (existing or resolved) in the QuarkusBootstrap. It might not end up being a quick fix though.

Sure. I try to implement a fix and would contact you in Zulip if required any further help :)
( I am just familiarizing myself with the project now and would love to contribute more)

Also, please close the PR at your convenience, I am not closing currently as if @stuartwdouglas wanted to add any more comments.

@AkMo3 AkMo3 closed this Feb 24, 2022
@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/backport? labels Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

io.quarkus:quarkus-jacoco does not work with QuarkusUnitTest
3 participants