Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redis host provider documentation #23806

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Add redis host provider documentation #23806

merged 1 commit into from
Feb 18, 2022

Conversation

VanillaSpoon
Copy link
Contributor

@VanillaSpoon VanillaSpoon commented Feb 18, 2022 •
edited
Loading

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 18, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@VanillaSpoon VanillaSpoon changed the title Add redis host provider documentation. Issue #23787 Add redis host provider documentation. Feb 18, 2022
machi1990
machi1990 requested changes Feb 18, 2022
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, thanks for the quick turn around and the PR.

I've added some small suggestions.

@machi1990
Copy link
Member

@VanillaSpoon thanks for taking a look on the feedback. Can you squash the 2 commits into one? It should be good to merge once that is done.

@VanillaSpoon
Copy link
Contributor Author

Thanks for the feedback @machi1990. I've squashed the commits.

@machi1990 machi1990 merged commit d9d10e9 into quarkusio:main Feb 18, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 18, 2022
@machi1990
Copy link
Member

machi1990 commented Feb 18, 2022 •
edited
Loading

Congrats on your first PR @VanillaSpoon. Let me know if you'll be interested on moving on to quarkusio/quarkus-quickstarts#1060

@VanillaSpoon
Copy link
Contributor Author

Thanks @machi1990.
Yea, Im happy to move to it. I'll just need a brief on where in redis-quickstart and how you would like it implemented :)

@gsmet gsmet changed the title Add redis host provider documentation. Add redis host provider documentation Feb 21, 2022
@VanillaSpoon VanillaSpoon deleted the DocumentRedisHostProvider branch February 21, 2022 14:18
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.7.2.Final
Development

Successfully merging this pull request may close these issues.

Document redis host provider or give an example
3 participants
@VanillaSpoon @machi1990 @gsmet