Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document redis host provider or give an example #23787

Closed
machi1990 opened this issue Feb 17, 2022 · 3 comments · Fixed by #23806
Closed

Document redis host provider or give an example #23787

machi1990 opened this issue Feb 17, 2022 · 3 comments · Fixed by #23806
Assignees
@VanillaSpoon
Labels
area/documentation area/redis good first issue Good for newcomers
Milestone
2.7.2.Final

Comments

@machi1990
Copy link
Member

machi1990 commented Feb 17, 2022 •
edited
Loading

Describe the bug

At the moment the redis guide is missing an example of the host provider feature

Expected behavior

The feature should be documented

Actual behavior

No documentation exists yet. We only have an integration test.

Additional information

The documentation can be added based on #16284 (comment). The documentation can be go just before the https://github.com/quarkusio/quarkus/blob/main/docs/src/main/asciidoc/redis.adoc#creating-clients-programmatically section.
@machi1990 machi1990 added the kind/bug Something isn't working label Feb 17, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 17, 2022

/cc @cescoffier, @gsmet

@machi1990 machi1990 added area/documentation good first issue Good for newcomers and removed kind/bug Something isn't working labels Feb 17, 2022
@machi1990
Copy link
Member Author

@VanillaSpoon will you be interested in this?

@VanillaSpoon
Copy link
Contributor

Yea, I'll work on it :) could you assign it to me?

@machi1990 machi1990 mentioned this issue Feb 17, 2022
Open
@VanillaSpoon VanillaSpoon mentioned this issue Feb 18, 2022
Merged
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 18, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VanillaSpoon VanillaSpoon

Labels
area/documentation area/redis good first issue Good for newcomers
Projects
None yet
Milestone
2.7.2.Final
Development

Successfully merging a pull request may close this issue.

Add redis host provider documentation
3 participants
@gsmet @machi1990 @VanillaSpoon