Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy activation of single letter aliases #23497

Merged
merged 1 commit into from
May 23, 2023

Conversation

stuartwdouglas
Copy link
Member

If you define a single letter alias in the interactive shell and it is
not mapped to an existing command you can activate it from the normal
terminal.

Fixes #23432

@quarkus-bot quarkus-bot bot added the area/core label Feb 8, 2022
@stuartwdouglas
Copy link
Member Author

@sdaschner any change you could try this out and let me know what you think?

@gsmet gsmet added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Feb 4, 2023
@sdaschner
Copy link
Contributor

@stuartwdouglas Sorry for the late reply, but very nice, just tried it out and works well :)

I hope this can still get rebased/merged

@stuartwdouglas stuartwdouglas marked this pull request as ready for review March 19, 2023 20:53
@stuartwdouglas
Copy link
Member Author

I have rebased.

@quarkus-bot

This comment has been minimized.

@sdaschner
Copy link
Contributor

@stuartwdouglas :)

@quarkus-bot

This comment has been minimized.

@maxandersen maxandersen added triage/quarkus-3 area/devmode and removed triage/needs-rebase This PR needs to be rebased first because it has merge conflicts labels May 22, 2023
@maxandersen
Copy link
Member

@stuartwdouglas trying to use this but not able to get it to work.

my console-aliases.txt seem to get wiped out constantly and is not being picked up either.

@maxandersen
Copy link
Member

okey got it working - there are a bunch of issues with console-aliases.txt but that is separate from here.

@maxandersen
Copy link
Member

ps. I rebased this to have it ready :)

If you define a single letter alias in the interactive shell and it is
not mapped to an existing command you can activate it from the normal
terminal.

Fixes quarkusio#23432
@maxandersen
Copy link
Member

I like this and +1 for it. I already wanna be able to have two letter aliases to allow to make sub-activations; but that's for another time :)

@maxandersen maxandersen self-requested a review May 22, 2023 15:38
Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quarkus-bot

This comment has been minimized.

@stuartwdouglas
Copy link
Member Author

Failure looks unrelated

@quarkus-bot
Copy link

quarkus-bot bot commented May 23, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@stuartwdouglas stuartwdouglas merged commit 32f52e2 into quarkusio:main May 23, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label May 23, 2023
@quarkus-bot quarkus-bot bot added this to the 3.2 - main milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Trigger dev terminal commands / aliases with keyboard shortcuts
4 participants