Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and document console-aliases.txt #33528

Open
maxandersen opened this issue May 22, 2023 · 2 comments
Open

fix and document console-aliases.txt #33528

maxandersen opened this issue May 22, 2023 · 2 comments
Labels
area/devmode good first issue Good for newcomers kind/bug Something isn't working

Comments

@maxandersen
Copy link
Member

Describe the bug

console-aliases.txt is in the code and used in #23497 PR but I found a few issues:

  1. console-aliases.txt is not documented anywhere. we should fix that :)
  2. the file gets rewritten somehow automatically meaning if you have two quarkus dev running things goes bad. (lines deleted)
  3. spaces are inconsistently handled.
    you must quote spaces, so alias ll=config set quarkus.log.console.format="max\ %d{HH:mm:ss,SSS}\ %-5p\ [%c{3.}]\ (%t)\ %s%e%n" works but when I add it I end up with rewritten file:
alias ll=config set quarkus.log.console.format="max\ %d{HH:mm:ss,SSS}\ %-5p\ [%c{3.}]\ (%t)\ %s%e%n"
quarkus.log.console.format=max\ %d{HH:mm:ss,SSS}\ %-5p\ [%c{3.}]\ (%t)\ %s%e%n
  1. lines without alias is ignored, nothing printed to console that file is problematic
  2. the file is created even if alias list is empty
  3. alias --help gives no info.
  4. alias not listed in help
  5. finally - local project aliases would be nice...i.e. not all aliases makes sense for everyone.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@maxandersen maxandersen added the kind/bug Something isn't working label May 22, 2023
@gsmet gsmet added the good first issue Good for newcomers label Aug 24, 2024
@Chu3laMan
Copy link

Chu3laMan commented Nov 9, 2024

Hi @maxandersen , I tried to fix the 2, 3, and 4 points mentioned above

#44402 (comment)

Still working on alias --help gives no info., Does the following inner SubCommandListRenderer class responsible of rendering commands @maxandersen ?

@Chu3laMan
Copy link

Chu3laMan commented Nov 23, 2024

@maxandersen would you detail the following two points

alias --help gives no info.
alias not listed in help

I already pushed a code belongs to the two points above would you check it?

furthermore, I found another bug related the same area which is the following

`quarkus$ test -help
Cannot invoke "org.aesh.command.impl.internal.ProcessedCommand.findOption(String)" because the return value of "org.aesh.command.impl.internal.ProcessedOption.parent()" is null

Thanks in advance
`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devmode good first issue Good for newcomers kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants