Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter for Java version with CLI & Maven #22848

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Add parameter for Java version with CLI & Maven #22848

merged 1 commit into from
Jan 13, 2022

Conversation

ebullient
Copy link
Member

@ebullient ebullient commented Jan 13, 2022

Resolves #21629

Command line argument:

Target language:
      --java=<javaVersion>   Target Java version.
                               Valid values: 11, 17
                               Default: 11
      --kotlin               Use Kotlin
      --scala                Use Scala

Maven parameter:

   -DjavaVersion=“11” 

or

   -DjavaVersion=“17” 

Other values will be be replaced with the default (which is 11), as before.

Changes minimized. There wasn’t a lot of reason to rename methods or chase the renaming of keys down through multiple levels of parameters: we just need to connect the machinery we have to an external.

Tested with CLI to create maven and gradle projects
Tested with Maven to create maven and gradle projects

@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Jan 13, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 13, 2022

Failing Jobs - Building 3bc1462

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.ImplementationFilesDevModeTest.main line 21 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

io.quarkus.gradle.devmode.InjectQuarkusAppPropertiesDevModeTest.main line 19 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@aloubyansky aloubyansky merged commit 8174d5a into quarkusio:main Jan 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 13, 2022
@ebullient ebullient deleted the java-version branch January 13, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform release/noteworthy-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a parameter to select the java version for generated Quarkus projects (CLI and Maven)
3 participants