Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed java_target to java_version resolved #21760

Closed
wants to merge 1 commit into from

Conversation

abmushfiq
Copy link

@abmushfiq abmushfiq commented Nov 28, 2021

Renamed java_target to java_version

Resolves #21629

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 28, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Nov 28, 2021
@abmushfiq abmushfiq changed the title Renamed java_target to java_version resolved #21721 Renamed java_target to java_version resolved Nov 28, 2021
@geoand geoand requested a review from ebullient November 29, 2021 09:26
@abmushfiq
Copy link
Author

@ebullient

@ebullient
Copy link
Member

ebullient commented Dec 1, 2021

Renaming the variable doesn't resolve the outstanding issue and may/will cause issues in templates or other areas that are looking for the (already existing/known) "java_target" attribute (via lookup in a map, or the transformed value...)

Minimally, independent-projects/tools/devtools-common/src/main/java/io/quarkus/devtools/codestarts/quarkus/QuarkusCodestartData.java and independent-projects/tools/devtools-common/src/test/java/io/quarkus/devtools/project/codegen/CreateProjectHelperTest.java also have to be changed.

But the bigger issue remains that renaming the variable / changing the key value does not resolve the issue.

@ebullient ebullient closed this Jan 12, 2022
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jan 12, 2022
@ebullient
Copy link
Member

For comparison / reference, see #22848. The key to resolving the issue was updating the CLI and the Maven Mojo to allow the parameter to be specified. Renaming variables is much less important (and depending on where you are in a release cycle, unnecessarily disruptive).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a parameter to select the java version for generated Quarkus projects (CLI and Maven)
2 participants