Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Kotlin Serialization native support #22756

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix Kotlin Serialization native support #22756

merged 1 commit into from
Jan 10, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 9, 2022

Fixes: #22624

@geoand geoand mentioned this pull request Jan 9, 2022
Closed
@quarkus-bot quarkus-bot bot added the area/rest label Jan 9, 2022
@geoand geoand requested a review from rsvoboda January 10, 2022 10:11
rsvoboda
rsvoboda approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kotlin-serialization is in Misc1, native tests passed, code changes look good to me.
Thanks for the fix!

@rsvoboda
Copy link
Member

@geoand should I merge or do you want review of the substitution by somebody more skilled in native alchemy?

@geoand
Copy link
Contributor Author

geoand commented Jan 10, 2022 •
edited
Loading

@rsvoboda I think it's perfectly safe 😎.

Thanks for the review

@rsvoboda rsvoboda merged commit 6a36ecf into quarkusio:main Jan 10, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 10, 2022
@geoand geoand deleted the #22624 branch January 10, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda approved these changes

Assignees
No one assigned
Labels
area/kotlin area/rest
Projects
None yet
Milestone
2.7.0.CR1
Development

Successfully merging this pull request may close these issues.

kotlin-serialization doesn't have native mode coverage
2 participants
@geoand @rsvoboda