Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kotlin-serialization doesn't have native mode coverage #22624

Closed
rsvoboda opened this issue Jan 4, 2022 · 2 comments · Fixed by #22756
Closed

kotlin-serialization doesn't have native mode coverage #22624

rsvoboda opened this issue Jan 4, 2022 · 2 comments · Fixed by #22756
Assignees
Labels
area/kotlin kind/bug Something isn't working
Milestone

Comments

@rsvoboda
Copy link
Member

rsvoboda commented Jan 4, 2022

Describe the bug

kotlin-serialization doesn't have native mode coverage

Expected behavior

kotlin-serialization module has native mode coverage

Actual behavior

kotlin-serialization doesn't have native mode coverage

There is only ResourceTest.kt in integration-tests/kotlin-serialization module.

I tried to add IT variant for ResourceTest.kt, but the execution fails with

Serializer for class 'Person' is not found.
Mark the class as @Serializable or provide the serializer explicitly.

While the class Person is annotated with @Serializable

How to Reproduce?

Performed changes:

diff --git a/integration-tests/kotlin-serialization/pom.xml b/integration-tests/kotlin-serialization/pom.xml
index e72059383f..4508080216 100644
--- a/integration-tests/kotlin-serialization/pom.xml
+++ b/integration-tests/kotlin-serialization/pom.xml
@@ -119,12 +119,6 @@
                     </pluginOptions>
                 </configuration>
             </plugin>
-            <plugin>
-                <artifactId>maven-failsafe-plugin</artifactId>
-                <configuration>
-                    <skip>true</skip>
-                </configuration>
-            </plugin>
             <plugin>
                 <groupId>io.quarkus</groupId>
                 <artifactId>quarkus-maven-plugin</artifactId>
diff --git a/integration-tests/kotlin-serialization/src/test/kotlin/io/quarkus/it/kotser/ResourceTest.kt b/integration-tests/kotlin-serialization/src/test/kotlin/io/quarkus/it/kotser/ResourceTest.kt
index f7b11b299c..0cb7300e09 100644
--- a/integration-tests/kotlin-serialization/src/test/kotlin/io/quarkus/it/kotser/ResourceTest.kt
+++ b/integration-tests/kotlin-serialization/src/test/kotlin/io/quarkus/it/kotser/ResourceTest.kt
@@ -7,7 +7,7 @@ import org.hamcrest.CoreMatchers.`is`
 import org.junit.jupiter.api.Test

 @QuarkusTest
-class ResourceTest {
+open class ResourceTest {
     @Test
     fun testGet() {
         given()

ResourceIT.kt

package io.quarkus.it.kotser

import io.quarkus.test.junit.QuarkusIntegrationTest

@QuarkusIntegrationTest
class ResourceIT : ResourceTest()

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

Quarkus main

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@rsvoboda rsvoboda added the kind/bug Something isn't working label Jan 4, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 4, 2022

/cc @evanchooly

geoand added a commit to geoand/quarkus that referenced this issue Jan 9, 2022
@geoand
Copy link
Contributor

geoand commented Jan 9, 2022

#22756 fixes the issue and will definitely be needed for Quarkus 2.7 to make Kotlin Serialization work properly in native

@geoand geoand self-assigned this Jan 9, 2022
rsvoboda added a commit that referenced this issue Jan 10, 2022
Fix Kotlin Serialization native support
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kotlin kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants