Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that QuarkusTestProfileAwareClassOrderer is now registered by default #21748

Merged
merged 1 commit into from
Nov 27, 2021
Merged

Document that QuarkusTestProfileAwareClassOrderer is now registered by default #21748

merged 1 commit into from
Nov 27, 2021

Conversation

famod
Copy link
Member

@famod famod commented Nov 27, 2021

This part slipped through in #21610.

I briefly thought about moving it to a separate section (because the orderer now not only covers profiles) but I think it's good enough.

Two questions:

  • Is there a "release aware way" to link to sources from adoc?
  • Shall I add something to the migration guide? The orderer shouldn't do any harm, it should actually improve things. And if someone has a custom orderer, it won't get in the way, so ...

@gsmet gsmet merged commit 0b5bea3 into quarkusio:main Nov 27, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Nov 27, 2021
@geoand
Copy link
Contributor

geoand commented Nov 27, 2021

Two questions:

* Is there a "release aware way" to link to sources from adoc?

Not that I know of

* Shall I add something to the migration guide? The orderer shouldn't do any harm, it should actually improve things. And if someone has a custom orderer, it won't get in the way, so ...

I don't think we need to.

@famod famod deleted the doc-test-class-orderer branch December 1, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants